fix(engine): declare web-tree-sitter/tree-sitter-wasms as root devDependencies - #9242
Merged
Conversation
…endencies test/unit/repo-map.test.ts imports both directly from the repo root, but they were only declared under packages/loopover-engine/package.json. Pinning web-tree-sitter back to ^0.20.8 (#9234) changed npm's hoisting decision and left both packages nested under packages/loopover-engine/node_modules/ only, breaking that root-level test's module resolution in CI. Declaring them as root devDependencies (matching the engine's pinned version) makes them resolvable from root-level tests regardless of hoisting.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9242 +/- ##
=======================================
Coverage ? 95.21%
=======================================
Files ? 729
Lines ? 59151
Branches ? 20947
=======================================
Hits ? 56321
Misses ? 1613
Partials ? 1217
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9234. Pinning `web-tree-sitter` back to `^0.20.8` fixed the engine's own `tsc` build, but changed npm's hoisting decision: both `web-tree-sitter` and `tree-sitter-wasms` ended up nested under `packages/loopover-engine/node_modules/` only, breaking `test/unit/repo-map.test.ts` (a pre-existing root-level test that imports both directly) — `Cannot find package 'web-tree-sitter'`. This was failing `validate-tests` on every open PR based on current `main`.
Declares both as explicit root `devDependencies` (matching the engine's pinned version), so they resolve from root-level tests regardless of hoisting.
Test plan