fix(signals): wire open-PR pressure scenarios into the branch scenario summary (#348)

[oktofeesh1]

The bug

The open-PR pressure strategy feature from #348 is dark in production. simulateOpenPrPressure (src/services/open-pr-pressure-scenarios.ts) computes a contributor strategy comparison — open another PR now / wait / clean up existing work first — ranked by repo queue pressure and miner-vs-maintainer lane. Its output is rendered by renderPublicScenarioSummary (src/scenarios/scenario-summary.ts), which fills the scenario options and headline from it.

Both halves are implemented and unit-tested — but the only production caller, buildLocalBranchAnalysis (src/signals/local-branch.ts), never built or passed pressureSimulation. So:

• scenarioSummary.options was always [] in analyze-branch / preflight / local-diff,
• the strategy headline never fired,
• and simulateOpenPrPressure had zero production callers (only its test referenced it).

The fix

Build the simulation at the existing call site and pass it through:

• roleContext is already in scope (built a few lines above),
• queueHealth is derived with the same buildCollisionReport → buildQueueHealth pair the pr-status route uses,
• contributorOpenPrCount is the contributor's own open PRs.

Pure and read-only; the renderer already runs every line through sanitizePublicComment, so output stays public-safe.

Test

test/unit/local-branch.test.ts now asserts scenarioSummary.options is populated — 3 ranked options, exactly one recommended, each with a non-empty label and nextStep — the regression that was silently empty before. Full npm run test:coverage stays green (branches 97.09%).

🤖 Generated with Claude Code

[ghost]

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal	Result	Evidence	Action
Gate result	⚠️ Skipped	#923 is no longer open.	No action.

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

[superagent-security]

⚠️ Contributor trust inconclusive. Click here for more info: Superagent Dashboard

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (e9234e8) to head (bbde981).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage   96.60%   96.61%           
=======================================
  Files         109      109           
  Lines       14895    14898    +3     
  Branches     5384     5385    +1     
=======================================
+ Hits        14390    14393    +3     
  Misses        104      104           
  Partials      401      401           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ghost]

🔍 Maintainer review

Reviewed 2 file(s) — ✅ all CI green.

Suggested action: ✅ Safe to merge — both reviewers found no blocking issues.

Reviewer A · gpt-oss-120b — recommends ✅ merge
The change correctly wires open‑PR pressure simulation into the public scenario summary and adds a comprehensive test. Types and imports appear consistent, no new external fetches or secret handling are introduced, and the public output still passes the sanitizer. The added logic is confined to scenario generation and does not weaken auth or DB handling. Tests cover the new behavior, and existing test suite should remain green.

Suggestions

• Verify that renderPublicScenarioSummary signature includes the new pressureSimulation field and that all callers are updated.
• Run the TypeScript compiler to ensure buildCollisionReport, buildQueueHealth, and simulateOpenPrPressure are exported correctly.
• Add a brief comment describing the shape of pressureSimulation for future maintainers.
• Consider sanitizing any dynamic text inside the generated option labels with isPublicSafeText to guarantee the public/private boundary.

Worth double-checking

• If renderPublicScenarioSummary is not updated elsewhere, a compile‑time error may occur.
• UI components that previously assumed options could be empty might need to handle the new non‑empty list.
• Unexpected forbidden terms could appear in option labels if underlying simulation logic is not properly sanitized.

Reviewer B · nemotron-3-120b-a12b — recommends ✅ merge
The change correctly wires the open-PR pressure simulation into the branch scenario summary, fixing the issue where options were always empty. The added test validates the expected behavior (3 options with ranks, one recommended). No public/private boundary violations are evident; the simulation outputs are consumed by the existing public scenario summary renderer which includes sanitization. The change is localized, follows existing patterns, and includes appropriate test coverage.

No blocking issues spotted.