feat(scoring): model upstream review-collateral and non-code caps (Fixes #809)

[kiannidev]

Summary

• Adds MAX_OPEN_PR_REVIEW_COLLATERAL_MULTIPLIER, MAX_LINES_SCORED_FOR_NON_CODE_EXT, and DEFAULT_ISSUE_DISCOVERY_SHARE to the scoring constant snapshot so upstream sync no longer drops them as unmodeled drift.
• Models open-PR review-collateral in score preview: exposes reviewCollateralMultiplier and applies it to effective collateralFraction (OPEN_PR_COLLATERAL_PERCENT × multiplier), matching upstream's calculate_review_collateral_multiplier.
• Caps non-code token contribution when nonCodeLines exceeds the upstream line cap (wired from local-branch analysis); registry normalization now defaults missing issue_discovery_share from DEFAULT_ISSUE_DISCOVERY_SHARE.

Fixes #809

Test plan

• npm run typecheck
• npm test -- test/unit/scoring.test.ts test/unit/registry.test.ts
• npm run ui:openapi (OpenAPI schema includes reviewCollateralMultiplier)
• CI green on PR

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[ghost]

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal	Result	Evidence	Action
Gate result	⚠️ Skipped	#916 is no longer open.	No action.

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.60%. Comparing base (2973ff7) to head (022d306).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files         109      109           
  Lines       14914    14924   +10     
  Branches     5390     5392    +2     
=======================================
+ Hits        14408    14418   +10     
  Misses        104      104           
  Partials      402      402           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ghost]

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

⛔ Maintainer review — Not merged

Reviewed 9 changed file(s) — two independent AI reviewers, synthesized.

ℹ️ This PR conflicts with main and can't be merged as-is. Conflicting file(s): apps/gittensory-ui/public/openapi.json, src/api/routes.ts, src/scoring/model.ts, src/scoring/preview.ts, src/signals/local-branch.ts, test/unit/scoring.test.ts. Resolve the conflict(s) and open a fresh PR.

Merge readiness: ✅ Mergeable (conflicting) · all CI checks green/neutral/skipped.

Summary

The change correctly adds support for upstream review collateral multiplier, non‑code line capping, and default issue‑discovery share. Types, schemas, validation, and tests are updated accordingly. No correctness or security issues are introduced, and all CI checks pass.

💡 Nits — non-blocking, optional

• Add documentation for new constants.
• Update README to reflect new scoring inputs.
• Consider adding JSDoc comments for the new constants (MAX_OPEN_PR_REVIEW_COLLATERAL_MULTIPLIER, MAX_LINES_SCORED_FOR_NON_CODE_EXT) to document their purpose.
• Update any internal documentation or README that describes scoring model fields to include the new reviewCollateralMultiplier and non‑code line handling.
• Consider adding a comment explaining the purpose of the DEFAULT_ISSUE_DISCOVERY_SHARE constant in src/scoring/model.ts.
• Consider adding a comment explaining the purpose of the nonCodeLines field in src/scoring/preview.ts and src/api/routes.ts.
• Consider adding a comment explaining the purpose of the reviewCollateralMultiplier field in src/scoring/preview.ts and src/api/routes.ts.
• Consider adding a comment explaining the purpose of the applyNonCodeLineCap function in src/scoring/preview.ts.

This repo uses one-shot review: a rejected PR is closed, not iterated in place. Address the above and open a new focused PR.

Route	Viewport	Before	After
/	desktop
	mobile

Before = production · After = this PR's preview deploy.

[JSONbored]

merge conflicts, please resubmit.

[kiannidev]

Hi, @JSONbored
Please re-review this PR.
This PR is closed without any reason or feedback...