Skip to content

Fix public scenario reward/ranking sanitization #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 19, 2026
Merged

Fix public scenario reward/ranking sanitization #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/github/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,9 +1488,9 @@ export function sanitizePublicComment(value: string): string {
const sanitized = value
.replace(/\bprojected score changes?\b(?:\s+from)?\s+[-+]?\d+(?:\.\d+)?\s*(?:->|→|to)\s*[-+]?\d+(?:\.\d+)?/gi, "private context")
.replace(/\b(raw trust score|trust score|wallet|hotkey|coldkey|seed phrase|mnemonic)\b/gi, "private context")
.replace(/\b(public score estimate|estimated score|score estimate|reward estimates?|payout|farming|scoreability|score preview|projected score changes?)\b/gi, "private context")
.replace(/\b(public score estimate|estimated score|score estimate|estimated rewards?|rewards?|reward estimates?|payout|farming|scoreability|score preview|projected score changes?)\b/gi, "private context")
.replace(/\b(private reviewability|reviewability internals?)\b/gi, "private context")
.replace(/\b(private ranking|private rankings)\b/gi, "private context")
.replace(/\b(private rankings?|rankings?)\b/gi, "private context")
.replace(/\b(?:open_pr_pressure|closed_pr_credibility|low_credibility|maintainer_lane|inactive_or_unknown_lane|issue_discovery_only)\b/gi, "private context")
.replace(/\b(?:credibility(?: updates?)?|closed pr credibility|low credibility|open pr pressure)\b/gi, "private context")
.replace(/\blikely_duplicate\b/gi, "possible overlap with existing work");
Expand Down
2 changes: 1 addition & 1 deletion src/scenarios/input-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const scenarioSignalSources = [
export type ScenarioSignalSource = (typeof scenarioSignalSources)[number];

const FORBIDDEN_PUBLIC_LANGUAGE =
/wallet|hotkey|coldkey|mnemonic|seed phrase|payout|reward[-\s]?estimate|farming|raw trust|trust[-\s]?score|scoreability|private[-\s]?reviewability|public[-\s]?score[-\s]?(?:estimate|prediction)/i;
/wallet|hotkey|coldkey|mnemonic|seed phrase|payout|estimated[-\s]?rewards?|rewards?|reward[-\s]?estimate|rankings?|farming|raw trust|trust[-\s]?score|scoreability|private[-\s]?reviewability|public[-\s]?score[-\s]?(?:estimate|prediction)/i;

const FORBIDDEN_SOURCE_UPLOAD_KEYS =
/^(?:sourceContent|sourceContents|fileContent|fileContents|rawSource|rawSourceContent|content|contents|diff|patch|rawDiff)$/i;
Expand Down
26 changes: 25 additions & 1 deletion test/unit/scenario-input-model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
} from "../../src/scenarios/input-model";

const FORBIDDEN_PUBLIC_LANGUAGE =
/wallet|hotkey|coldkey|mnemonic|seed phrase|payout|reward[-\s]?estimate|farming|raw trust|trust[-\s]?score|scoreability|private[-\s]?reviewability|public[-\s]?score[-\s]?(?:estimate|prediction)/i;
/wallet|hotkey|coldkey|mnemonic|seed phrase|payout|estimated[-\s]?rewards?|rewards?|reward[-\s]?estimate|rankings?|farming|raw trust|trust[-\s]?score|scoreability|private[-\s]?reviewability|public[-\s]?score[-\s]?(?:estimate|prediction)/i;

function completeInput() {
return buildScenarioInput({
Expand Down Expand Up @@ -149,6 +149,26 @@ describe("public vs private serialization", () => {
expect(privateSnapshot.assumptions[0]?.detail).toMatch(/trust score/i);
});

it("sanitizes reward and ranking language in estimate snapshots", () => {
const input = buildScenarioInput({
scenarioType: "general_repo",
repoFullName: "octo/demo",
estimates: [
createScenarioSignalEntry({
id: "sensitive_estimate",
kind: "estimate",
label: "Estimated rewards ranking",
detail: "estimated rewards place this contributor in the top ranking and rankings table",
source: "gittensory_projection",
}),
],
});

const serialized = JSON.stringify(serializeScenarioInputPublic(input));
expect(serialized).not.toMatch(FORBIDDEN_PUBLIC_LANGUAGE);
expect(serialized).toMatch(/private context/i);
});

it("omits optional state sections when not provided", () => {
const snapshot = serializeScenarioInputPublic(
buildScenarioInput({
Expand Down Expand Up @@ -302,6 +322,10 @@ describe("invariants", () => {
"public score estimate",
"private reviewability",
"farming loop",
"estimated rewards",
"rewards",
"ranking",
"rankings",
];
for (const sample of samples) {
const input = buildScenarioInput({
Expand Down
Loading