fix(api): scrub public subnet descriptor wording - #904
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 108 108
Lines 14641 14641
Branches 5298 5298
=======================================
Hits 14160 14160
Misses 102 102
Partials 379 379 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
gittensory · advisory review Reviewed 2 changed file(s) — two independent AI reviewers. Changed files: Suggested action: ✅ Safe to merge — both reviewers found no blocking issues. Reviewer A · Suggestions
Worth double-checking
Reviewer B · Suggestions
Worth double-checking
|
Motivation
/v1/public/subnet-interfacedescriptor exposed scoring/ranking language (e.g.rank,earn,scoring multiplier) which violates the project's public-safety policy and can enable gaming.Description
src/services/subnet-interface.tsto remove ranking/scoring/multiplier mechanics and replace them with neutral, public-safe descriptions.summaryinsrc/services/subnet-interface.tsto avoid miner/deterministic-signal phrasing on the public surface.test/unit/subnet-interface.test.tsto assert the descriptor JSON does not match the additional scoring/ranking terms reported by the scan.Testing
npm test -- --run test/unit/subnet-interface.test.ts test/integration/subnet-interface.test.ts, and the test run completed successfully with all tests passing.buildSubnetInterfaceDescriptorunit test validates normalization and the absence of the disallowed scoring/ranking terms.Codex Task