Skip to content

fix(engine): key denyResult decision off eventType, not stage #9002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 26, 2026
Merged

fix(engine): key denyResult decision off eventType, not stage #9002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/loopover-engine/src/governor/chokepoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function denyResult(input: {
eventType: input.eventType,
repoFullName: input.repoFullName,
actionClass: input.actionClass,
decision: input.stage === "kill_switch" ? "paused" : input.eventType === "throttled" ? "throttle" : "deny",
decision: input.eventType === "kill_switch" ? "paused" : input.eventType === "throttled" ? "throttle" : "deny",
reason: input.reason,
payload: { stage: input.stage, ...input.extraPayload },
},
Expand Down
1 change: 1 addition & 0 deletions packages/loopover-engine/test/chokepoint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ test("budget cap: the termination ceiling denies with a kill_switch eventType (h
);
assert.equal(decision.stage, "budget_cap");
assert.equal(decision.ledgerEvent.eventType, "kill_switch");
assert.equal(decision.ledgerEvent.decision, "paused", "a kill_switch eventType must record decision=paused regardless of which stage triggered it");
});

test("non-convergence: a stuck item denies before reputation/self-plagiarism run", () => {
Expand Down