fix(scoring): skip unmodeled-drift sync on garbage upstream constants bodies

[philluiz2323]

Problem

Closes #8902.

refreshScoringModelSnapshot correctly fails closed when a 200 constants.py body is semantically garbage and a verified last-good exists — but with no last-good (first run / prior fallback), execution continues and the drift-sync guard was only if (constantsResult.ok). That still ran findUnmodeledUpstreamConstants against HTML/LFS junk and could open a spurious upstream_drift_reports row.

Fix

Gate syncUnmodeledScoringConstantDrift on constantsUsable (the same recognized-count floor the fail-closed path already uses), not merely HTTP-ok.

Tests

• Existing no-last-good garbage bootstrap test now asserts listUpstreamDriftReports stays empty even when the junk body contains a parseable fake unmodeled constant name.
• Existing real-unmodeled path still opens a drift report (regression).

Reverting the guard fails the empty-reports assertion. git diff --check clean.

Scope

• Conventional Commit title
• Focused change
• Follows CONTRIBUTING.md
• Closes fix(scoring): stop garbage upstream bodies from creating false "unmodeled constants" drift reports #8902

Validation

• git diff --check
• Targeted vitest for garbage bootstrap + unmodeled scoring dimension paths (2 pass)
• Scoring-only; unrelated UI/MCP checks not exercised.

Safety

• No secrets / private scores exposed
• No UI changes (N/A evidence)

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.57%. Comparing base (b723ba8) to head (16ccc5c).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8972      +/-   ##
==========================================
+ Coverage   90.56%   90.57%   +0.01%     
==========================================
  Files          96       97       +1     
  Lines       22490    22558      +68     
  Branches     3884     3908      +24     
==========================================
+ Hits        20367    20433      +66     
  Misses       1945     1945              
- Partials      178      180       +2     

Flag	Coverage Δ
backend	97.05% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/scoring/model.ts	97.05% <100.00%> (ø)

[loopover-orb]

Warning

⏸️ LoopOver review result - manual review recommended

_{Review updated: 2026-07-26 15:20:47 UTC}

2 files · no blockers · CI green · clean

⏸️ Suggested Action - Manual Review

Decision drivers

• ✅ Code review — No blockers (No AI review summary)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8902
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 989 registered-repo PR(s), 565 merged, 125 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	philluiz2323; Gittensor profile; 989 PR(s), 125 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Linked issue satisfaction

Addressed
The diff changes line 137's guard from `if (constantsResult.ok)` to `if (constantsUsable)`, exactly matching the requested fix, and adds an assertion that `listUpstreamDriftReports` stays empty for a 200-with-garbage-body fetch with no last-good snapshot, even when the garbage contains a parseable fake unmodeled constant name.

Review context

• Author: philluiz2323
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, MDX, TypeScript, CSS, Cuda, HTML, Kotlin
• Official Gittensor activity: 989 PR(s), 125 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Decision record

• action: merge · clause: success
• config: 03a7f8b529a9 · pack: oss-anti-slop
• record: 763bc93a3043 (schema v2, head 16ccc5c)

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review