fix(engine): stop classifying non-CI YAML paths as ci changes - #8922
fix(engine): stop classifying non-CI YAML paths as ci changes#8922philluiz2323 wants to merge 1 commit into
Conversation
kindsFromPath tagged every .yml/.yaml file as ci via a bare-extension fallback, diluting the ci change-kind signal for configs like .loopover.yml. Classify ci only via CI_SEGMENTS path matches. Closes JSONbored#8873
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8922 +/- ##
==========================================
- Coverage 93.84% 93.84% -0.01%
==========================================
Files 803 803
Lines 80084 80084
Branches 24277 24276 -1
==========================================
- Hits 75157 75152 -5
- Misses 3562 3563 +1
- Partials 1365 1369 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-26 13:55:17 UTC
Review summary Nits — 3 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
.yml/.yamlextension fallback inkindsFromPathso only realCI_SEGMENTSpath matches (.github,workflows) classify as"ci"..loopover.yml,docs/mkdocs.yml, andconfig/app.yamldo not produce"ci", while.github/workflows/ci.ymlstill does.Closes #8873
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm --workspace @loopover/engine run buildnode --test dist-test/objective-anchor.test.js(20 passed)If any required check was skipped, explain why:
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — engine path-classification helper only; no UI surface change.
Notes