Skip to content

fix(engine): stop classifying non-CI YAML paths as ci changes - #8922

Closed
philluiz2323 wants to merge 1 commit into
JSONbored:mainfrom
philluiz2323:fix/8873-objective-anchor-yaml-ci
Closed

fix(engine): stop classifying non-CI YAML paths as ci changes#8922
philluiz2323 wants to merge 1 commit into
JSONbored:mainfrom
philluiz2323:fix/8873-objective-anchor-yaml-ci

Conversation

@philluiz2323

Copy link
Copy Markdown
Contributor

Summary

  • Drop the bare .yml/.yaml extension fallback in kindsFromPath so only real CI_SEGMENTS path matches (.github, workflows) classify as "ci".
  • Add a negative test that .loopover.yml, docs/mkdocs.yml, and config/app.yaml do not produce "ci", while .github/workflows/ci.yml still does.

Closes #8873

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm --workspace @loopover/engine run build
  • node --test dist-test/objective-anchor.test.js (20 passed)
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Engine package-local build + objective-anchor suite cover the change. Full monorepo typecheck/coverage not re-run locally.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — engine path-classification helper only; no UI surface change.

Notes

kindsFromPath tagged every .yml/.yaml file as ci via a bare-extension
fallback, diluting the ci change-kind signal for configs like
.loopover.yml. Classify ci only via CI_SEGMENTS path matches.

Closes JSONbored#8873
@philluiz2323
philluiz2323 requested a review from JSONbored as a code owner July 26, 2026 13:31
@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.84%. Comparing base (8a3d2c9) to head (67256e1).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
packages/loopover-engine/src/objective-anchor.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8922      +/-   ##
==========================================
- Coverage   93.84%   93.84%   -0.01%     
==========================================
  Files         803      803              
  Lines       80084    80084              
  Branches    24277    24276       -1     
==========================================
- Hits        75157    75152       -5     
- Misses       3562     3563       +1     
- Partials     1365     1369       +4     
Flag Coverage Δ
backend 95.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-engine/src/objective-anchor.ts 23.33% <0.00%> (-0.84%) ⬇️

... and 1 file with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 26, 2026
@loopover-orb

loopover-orb Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - fixes required

Review updated: 2026-07-26 13:55:17 UTC

2 files · 1 AI reviewer · no blockers · CI failing · unstable

🛑 Suggested Action - Fix Blockers

Review summary
This PR removes the bare `.yml`/`.yaml` extension fallback from `kindsFromPath` in objective-anchor.ts:231 so only paths matching CI_SEGMENTS (`.github`, `workflows`) classify as `"ci"`, fixing the over-broad classification described in #8873. The fix is correctly targeted at the source (the classifier itself, not a downstream consumer), and the new test directly exercises the previously-broken behavior (`.loopover.yml`, `docs/mkdocs.yml`, `config/app.yaml` no longer classified as ci) alongside a positive case (`.github/workflows/ci.yml` still classified as ci) confirming no regression. `.loopover.yml` still correctly falls into `"config"` via CONFIG_FILENAMES, and `docs/mkdocs.yml`/`config/app.yaml` still get `"docs"`/`"config"` from other independent branches, so no classification is silently dropped.

Nits — 3 non-blocking
  • The codecov/patch check failed at 0.00% (target 99%) — likely a tooling/reporting artifact since the diff does add a directly relevant test, but worth confirming the coverage tool is picking up the new test file correctly.
  • test/objective-anchor.test.ts:391 doesn't test a bare `.yml` file outside any recognized module path (e.g. a top-level `something.yml` with no other classifying signal) to confirm it now falls through to `["unknown"]` rather than silently matching some other branch.
  • Consider adding one assertion for a root-level `.yml` file with no docs/config/ci signal to fully pin down the post-fix fallback behavior.

CI checks failing

  • codecov/patch — 0.00% of diff hit (target 99.00%)

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8873
Related work ⚠️ Same linked issue: #8921 Another open PR references the same linked issue.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 987 registered-repo PR(s), 565 merged, 125 issue(s).
Contributor context ✅ Confirmed Gittensor contributor philluiz2323; Gittensor profile; 987 PR(s), 125 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff removes the bare .yml/.yaml extension fallback so ci classification now relies solely on CI_SEGMENTS path matches, and adds a negative test confirming .loopover.yml, docs/mkdocs.yml, and config/app.yaml no longer produce the "ci" kind while a real .github/workflows path still does.

Review context
Contributor next steps
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(engine): objective-anchor misclassifies any .yml/.yaml file anywhere as a "ci" change kind

1 participant