Skip to content

fix(agent): keep public-safe packets free of private evidence #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 19, 2026
Merged

fix(agent): keep public-safe packets free of private evidence #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/services/agent-orchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,11 @@ function actionRecord(args: {
payload: Record<string, JsonValue>;
evidence?: RecommendationEvidence | undefined;
}): AgentActionRecord {
const evidence = args.evidence ?? defaultRecommendationEvidence(args.actionType);
const safetyClass = args.safetyClass ?? "private";
const payload = { ...args.payload };
if (safetyClass !== "public_safe") {
payload.recommendationEvidence = (args.evidence ?? defaultRecommendationEvidence(args.actionType)) as unknown as JsonValue;
}
const action: AgentActionRecord = {
id: `${args.run.id}:${String(args.index).padStart(2, "0")}:${args.actionType}`,
runId: args.run.id,
Expand All @@ -617,11 +621,8 @@ function actionRecord(args: {
rerunWhen: args.rerunWhen,
publicSafeSummary: sanitizePublicSummary(args.publicSafeSummary),
approvalRequired: args.approvalRequired ?? true,
safetyClass: args.safetyClass ?? "private",
payload: {
...args.payload,
recommendationEvidence: evidence as unknown as JsonValue,
},
safetyClass,
payload,
createdAt: nowIso(),
};
return withAgentActionExplanationCard(action);
Expand Down
5 changes: 5 additions & 0 deletions test/unit/agent-orchestrator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,9 @@ describe("agent orchestrator", () => {
freshness: "fresh",
sources: expect.arrayContaining([expect.objectContaining({ name: "local_branch_metadata", source: "metadata_only" })]),
});
expect(actions[1]).toMatchObject({ actionType: "prepare_pr_packet", safetyClass: "public_safe", approvalRequired: false });
expect(actions[1]?.payload.recommendationEvidence).toBeUndefined();
expect(JSON.stringify(actions[1]?.payload)).not.toMatch(/private score preview|score_preview|linked_issue_multiplier|scoreabilityStatus/i);
expect(blockers[0]).toMatchObject({ status: "ready", recommendation: "No hard scoreability blocker is visible from local metadata." });
expect(blockedActions.map((entry) => entry.actionType)).toEqual(["preflight_branch", "prepare_pr_packet", "explain_score_blockers"]);
expect(blockedActions[0]?.scoreabilityImpact).toContain("scenario projections");
Expand Down Expand Up @@ -1044,6 +1047,8 @@ describe("agent orchestrator", () => {
expect(preflight.actions.map((action) => action.actionType)).toEqual(expect.arrayContaining(["preflight_branch", "prepare_pr_packet"]));
expect(packet.actions).toHaveLength(1);
expect(packet.actions[0]).toMatchObject({ actionType: "prepare_pr_packet", safetyClass: "public_safe", approvalRequired: false });
expect(packet.actions[0]?.payload.recommendationEvidence).toBeUndefined();
expect(JSON.stringify(packet.actions[0]?.payload)).not.toMatch(/private score preview|score_preview|linked_issue_multiplier|scoreabilityStatus/i);
expect(blockers.actions[0]).toMatchObject({ actionType: "explain_score_blockers", targetRepoFullName: "entrius/allways-ui" });
expect(JSON.stringify(preflight.actions)).toContain("linked_issue_bounty_historical");
expect(JSON.stringify(preflight.actions)).toContain("Source upload disabled");
Expand Down
Loading