test(miner-ui): cover bare-integer portfolio-queue identifier parsing - #8772
Conversation
Add direct resolvePortfolioQueueChatAction tests for release/requeue with a trailing bare integer, plus a negative case where a digit glued to a letter (v2) is not treated as an identifier. Closes JSONbored#8671
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-26 03:50:56 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
chat-portfolio-queue-resolve.test.tscovering the bare-integerIDENTIFIER_REarm:release acme/widgets 12andrequeue acme/widgets 12both resolveidentifier: "issue:12".release acme/widgets for sprint v2does not treatv2as an identifier (lookbehind/lookahead).Closes #8671
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpx eslint src/lib/chat-portfolio-queue-resolve.test.ts(exit 0, Prettier/LF clean)npx vitest run src/lib/chat-portfolio-queue-resolve.test.ts(3 passed)If any required check was skipped, explain why:
apps/**excluded fromcodecov/patch). Dedicated resolve test file exercises the pure parser without the actions suite's ui-kit import graph.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable — test-only; no visible UI change.
Notes