fix(scripts): scan packages/*/src/**/*.tsx in the branding-drift check - #8661
Conversation
The BRANDING_DRIFT_PATHSPECS listed both .ts and .tsx for the apps/* scope but only .ts for packages/*, despite the header framing packages/*/src as mirroring apps/*. That left the 48 loopover-ui-kit .tsx design-system components — the repo's highest-reuse UI surface — outside the git-grep scan, so a reintroduced pre-rebrand string in any of them would never trip the check (the exact class of bug JSONbored#6786). Add the missing packages/*/src/**/*.tsx pathspec. No packages .tsx file currently contains a flagged string, so the baseline is unchanged. Closes JSONbored#8657
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8661 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 798 798
Lines 79475 79475
Branches 24082 24082
=======================================
Hits 74525 74525
Misses 3565 3565
Partials 1385 1385
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-25 23:36:59 UTC
Review summary Nits — 2 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
fix(scripts): scan packages//src/**/.tsx in the branding-drift check
The BRANDING_DRIFT_PATHSPECS listed both .ts and .tsx for the apps/*
scope but only .ts for packages/, despite the header framing
packages//src as mirroring apps/*. That left the 48 loopover-ui-kit
.tsx design-system components — the repo's highest-reuse UI surface —
outside the git-grep scan, so a reintroduced pre-rebrand string in any
of them would never trip the check (the exact class of bug #6786).
Add the missing packages//src/**/.tsx pathspec. No packages .tsx file
currently contains a flagged string, so the baseline is unchanged.
Closes #8657