Skip to content

fix(scripts): scan packages/*/src/**/*.tsx in the branding-drift check - #8661

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-8657
Jul 25, 2026
Merged

fix(scripts): scan packages/*/src/**/*.tsx in the branding-drift check#8661
JSONbored merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-8657

Conversation

@bitfathers94

Copy link
Copy Markdown
Contributor

fix(scripts): scan packages//src/**/.tsx in the branding-drift check

The BRANDING_DRIFT_PATHSPECS listed both .ts and .tsx for the apps/*
scope but only .ts for packages/, despite the header framing
packages/
/src as mirroring apps/*. That left the 48 loopover-ui-kit
.tsx design-system components — the repo's highest-reuse UI surface —
outside the git-grep scan, so a reintroduced pre-rebrand string in any
of them would never trip the check (the exact class of bug #6786).

Add the missing packages//src/**/.tsx pathspec. No packages .tsx file
currently contains a flagged string, so the baseline is unchanged.

Closes #8657

The BRANDING_DRIFT_PATHSPECS listed both .ts and .tsx for the apps/*
scope but only .ts for packages/*, despite the header framing
packages/*/src as mirroring apps/*. That left the 48 loopover-ui-kit
.tsx design-system components — the repo's highest-reuse UI surface —
outside the git-grep scan, so a reintroduced pre-rebrand string in any
of them would never trip the check (the exact class of bug JSONbored#6786).

Add the missing packages/*/src/**/*.tsx pathspec. No packages .tsx file
currently contains a flagged string, so the baseline is unchanged.

Closes JSONbored#8657
@bitfathers94
bitfathers94 requested a review from JSONbored as a code owner July 25, 2026 23:13
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.77%. Comparing base (ee390f5) to head (a8f5373).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8661   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files         798      798           
  Lines       79475    79475           
  Branches    24082    24082           
=======================================
  Hits        74525    74525           
  Misses       3565     3565           
  Partials     1385     1385           
Flag Coverage Δ
backend 95.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier. labels Jul 25, 2026
@loopover-orb

loopover-orb Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-25 23:36:59 UTC

2 files · 1 AI reviewer · no blockers · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
Adds the missing `packages/*/src/**/*.tsx` pathspec to BRANDING_DRIFT_PATHSPECS, closing the gap where packages' .tsx files (unlike apps' .tsx files) were excluded from the branding-drift git-grep scan. The fix is a single well-targeted line, backed by two new tests confirming the pathspec is passed to exec and that a matching hit is correctly counted, and the PR correctly notes no baseline update is needed since no packages .tsx file currently contains a flagged string. Closes issue #6786's class of bug via #8657 as required.

Nits — 2 non-blocking
  • The two new tests (test/unit/check-branding-drift-script.test.ts:53-69) are somewhat redundant with the existing apps/* pathspec test above them and could be merged into one assertion block for brevity.
  • Consider adding a one-line comment near the packages/* pathspec block noting it must stay in sync with apps/* (mirrors the header's stated intent) to prevent this exact drift from recurring for future file extensions.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8657
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ⚠️ 20/25 Preflight is ready, but the PR body does not name the validation run.
Contributor workload ✅ 10/10 Author activity: 40 registered-repo PR(s), 25 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bitfathers94; Gittensor profile; 40 PR(s), 0 issue(s).
Improvement ✅ Minor risk: clean · value: minor
Linked issue satisfaction

Addressed
The diff adds the missing "packages/*/src/**/*.tsx" pathspec matching the apps/* pattern, and includes tests asserting the pathspec is passed to git grep and that a packages/*/src/*.tsx hit is captured in scanBrandingHits' output, satisfying all three deliverables.

Review context
  • Author: bitfathers94
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: TypeScript
  • Official Gittensor activity: 40 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add validation command/output.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 25, 2026
@JSONbored
JSONbored merged commit 679ba78 into JSONbored:main Jul 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(scripts): check-branding-drift.ts scans packages/*/src/**/*.ts but not the matching .tsx files

2 participants