feat(miner): capture bounded candidate context in eligibility-exclusion metadata - #8561
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8561 +/- ##
==========================================
- Coverage 89.58% 89.09% -0.49%
==========================================
Files 97 98 +1
Lines 22706 22955 +249
Branches 3872 3960 +88
==========================================
+ Hits 20341 20452 +111
- Misses 2187 2292 +105
- Partials 178 211 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-24 21:00:29 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
recordEligibilityExclusionSignalsindiscover-cli.tsso each real-run eligibility exclusion records boundedmetadataon the fired event:labels,assignees, andowner(when present on the excluded candidate).truncated: trueonly when a cap actually clamps; absent fields omitted (nonull, no empty-array placeholders).contribution-profile-filter.tsuntouched; dry-run still records nothing; best-effort discipline preserved (metadata capture cannot abort discovery).Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run build:minernpx vitest run test/unit/miner-discover-cli-eligibility-metadata.test.ts test/unit/miner-discover-cli.test.ts -t "eligibility-exclusion signal tracking|buildEligibilityExclusionMetadata"— 13 passednpm run build:miner && npx vitest run test/unit/miner-discover-cli-eligibility-metadata.test.ts test/unit/miner-discover-cli.test.ts -t "eligibility-exclusion signal tracking|buildEligibilityExclusionMetadata" --coverage.all=false --coverage && npx diff-cover coverage/lcov.info --compare-branch=origin/mainnpm run test:coverage(full unsharded gate)npm run test:cinpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
packages/loopover-miner/lib/discover-cli.ts). New unit tests import.tsvia variable specifier (miner-discover-cli-eligibility-metadata.test.ts) socodecov/patchgrades changed lines under--coverage.all=false. Fulltest:cileft to CI.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.