fix(queue): observe unresolved required-contexts lookups (#8358)

[claytonlin1110]

Summary

• Direction (a): keep RequiredStatusContextsLookup.resolved and consume it at the live-gate call site in runAgentMaintenancePlanAndExecute.
• When a branch-protection required-contexts read fails (resolved: false), emit loopover_required_contexts_unresolved_total and a structured required_contexts_branch_protection_unresolved warn — gate/merge/close disposition is unchanged.
• Cover the previously untested onFetchFailure path in cachedRequiredStatusContexts plus both branches of the new observer helper.
• Typecheck-safe mock: call onFetchFailure?.(...) because the callback parameter is optional on the type (fixes the validate-code failure that closed fix(queue): observe unresolved required-contexts lookups (#8358) #8433).

Closes #8358

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Backend-only queue change. Locally verified: npm run typecheck (the check that failed on fix(queue): observe unresolved required-contexts lookups (#8358) #8433), focused vitest + coverage on src/queue/ci-resolution.ts / the processors call-site regression in queue.test.ts, git diff --check, and npm audit --audit-level=moderate. Remaining validate-code steps unchanged by this diff and left to CI.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — no visible UI change (queue observability only).

State / title	JPG/PNG evidence
N/A

Notes

• Fresh PR after fix(queue): observe unresolved required-contexts lookups (#8358) #8433 was auto-closed on validate-code (onFetchFailure possibly undefined).
• Chose observability over deletion: resolved already gates durable CI-state write-through; this wires the remaining silent live-gate call site.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (2494517) to head (b1a97ee).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8447      +/-   ##
==========================================
- Coverage   92.42%   90.36%   -2.07%     
==========================================
  Files         791       99     -692     
  Lines       79294    25947   -53347     
  Branches    23950     5014   -18936     
==========================================
- Hits        73291    23446   -49845     
+ Misses       4866     2233    -2633     
+ Partials     1137      268     -869     

Flag	Coverage Δ
shard-1	80.43% <83.33%> (+22.67%)	⬆️
shard-2	31.90% <100.00%> (-15.78%)	⬇️
shard-3	40.01% <33.33%> (-16.56%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/ci-resolution.ts	98.64% <100.00%> (+0.09%)	⬆️
src/queue/processors.ts	95.73% <100.00%> (+<0.01%)	⬆️

... and 692 files with indirect coverage changes

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-24 13:48:04 UTC}

4 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR wires the previously-ignored `RequiredStatusContextsLookup.resolved` flag into an observer helper (`observeRequiredContextsLookup`) called right after `cachedRequiredStatusContexts` resolves in `runAgentMaintenancePlanAndExecute`, emitting a counter + structured warn when a branch-protection read fails, with gate disposition explicitly untouched. The `resolved` computation in `cachedRequiredStatusContexts` (ci-resolution.ts:99-107) is a real signal — `branchProtectionFetchFailed` is set via the `onFetchFailure` callback closure before the `.then` resolves — not a can't-occur guard, and the new tests exercise both the failure and success paths plus both branches of the observer (resolved true/false, nullish baseRef coalescing). The change is narrow, closes #8358 as required, and the mock's `onFetchFailure?.(...)` optional-call matches the described typecheck fix for #8433.

Nits — 4 non-blocking

• src/queue/ci-resolution.ts:122 uses a raw `console.warn(JSON.stringify(...))` rather than any shared structured-logger helper — worth confirming this matches the convention used by other warn-level observability call sites in this file/module rather than introducing a one-off pattern.
• The new `REQUIRED_CONTEXTS_UNRESOLVED_METRIC` constant isn't cross-referenced in any metrics catalog/dashboard doc in the diff — if one exists, confirm it's updated so this new counter is actually discoverable by whoever monitors branch-protection health.
• Consider whether `observeRequiredContextsLookup` should also fire when the `.catch(() => ({ requiredContexts: null, resolved: false }))` fallback in `fetchLiveCiAggregateWithRequiredContexts` (ci-resolution.ts) is hit, since that's another `resolved: false` path that currently only the direct `cachedRequiredStatusContexts` caller in processors.ts observes.
• test/unit/queue.test.ts:3276 asserts `toBeGreaterThanOrEqual(1)` rather than an exact count — fine for a shared-metric guard, but consider `resetMetrics()` placement is already handled correctly right before the assertion so this is just a minor precision nit.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8433, #8358
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (2 linked issues).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 399 registered-repo PR(s), 251 merged, 92 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	claytonlin1110; Gittensor profile; 399 PR(s), 92 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The PR wires the previously-unused RequiredStatusContextsLookup.resolved flag into the live-gate call site, emitting a metric and structured warn on unresolved branch-protection reads without changing gate/merge/close disposition, exactly matching the issue's stated direction (a).

Review context

• Author: claytonlin1110
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, TypeScript, Rust
• Official Gittensor activity: 399 PR(s), 92 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.