feat(calibration): operator visibility for the satisfaction-floor loosening loop - #8180
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-23 08:57:36 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
…sening loop (#8161) The loop's applied loosenings only existed as audit rows an operator had to query by hand. Adds loadSatisfactionFloorStatus: flag state, shipped vs LIVE floor, the validated stored override (reported even while the flag is off -- an operator must see a lingering row that would take effect the moment the flag flips, while liveFloor only follows it when on), and the applied history projected newest-first from the calibration.satisfaction_floor_loosened events with both split verdicts and sample sizes. Corrupt/non-object rows degrade to a nulls entry rather than hiding that an apply happened; every read fails safe. Served at GET /v1/internal/calibration/satisfaction-floor -- deliberately NOT flag-gated (visibility must survive a flag flip), same INTERNAL_JOB_TOKEN gate, aggregate numbers/verdicts only (leak-guard pinned). Closes #8161.
a4f3456 to
c1ba3ac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8180 +/- ##
==========================================
+ Coverage 81.77% 90.15% +8.38%
==========================================
Files 769 99 -670
Lines 77863 25257 -52606
Branches 23523 4725 -18798
==========================================
- Hits 63673 22771 -40902
+ Misses 11317 2214 -9103
+ Partials 2873 272 -2601
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Summary
loadSatisfactionFloorStatusreports the flag state, shipped vs live floor, the validated stored override — shown even while the flag is off, because an operator must see a lingering row that would take effect the moment the flag flips (whileliveFlooronly follows it when on) — and the applied-loosening history projected newest-first from thecalibration.satisfaction_floor_loosenedaudit events with both split verdicts and sample sizes.storedOverrideandliveFloor; every read fails safe.GET /v1/internal/calibration/satisfaction-floor— deliberately NOT flag-gated (visibility must survive a flag flip), sameINTERNAL_JOB_TOKENgate as its calibration siblings, aggregate numbers/verdicts only (leak-guard pinned).Closes #8161
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:testnpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:ci: 20,686 tests passed with exactly one failure — the known symlinked-node_modules worktree artifact inminer-package-skeleton, re-run green under a realnpm ci(alongside the status suite) after rebasing onto current main;ui:version-auditgreen on the rebased base. The touched run module holds 100% line+branch coverage across its suites (rebase absorbed feat(calibration): schedule the satisfaction-floor loosening tick with a one-shot apply alert #8175's tail cleanly).Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.401-without-token negative path tested; the endpoint is read-only and carries no corpus content of any kind.
UI Evidence
Not applicable — no UI change (internal operator endpoint).
Notes