fix(engine): add real packages/loopover-engine paths to ENGINE_DECISION_GUARDRAIL_GLOBS - #8133
Closed
JSONbored wants to merge 1 commit into
Closed
fix(engine): add real packages/loopover-engine paths to ENGINE_DECISION_GUARDRAIL_GLOBS#8133JSONbored wants to merge 1 commit into
JSONbored wants to merge 1 commit into
Conversation
…ON_GUARDRAIL_GLOBS src/settings/autonomy.ts and src/review/guardrail-config.ts are now 5-line #6203 re-export shims -- the real, substantive logic lives at the packages/loopover-engine paths instead. Neither real path was listed, so a PR editing the autonomy deny-by-default dial, or editing ENGINE_DECISION_GUARDRAIL_GLOBS/DEFAULT_HARD_GUARDRAIL_GLOBS itself to quietly remove entries, touched only the real engine-package file and never tripped the guardrail hold it should have. Every other exact-file entry in this list was checked and confirmed to still be a real, substantial file, not a shim -- this was an isolated gap from the #6203 migration. Closes #8012
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | d28d3aa | Commit Preview URL Branch Preview URL |
Jul 23 2026, 12:01 AM |
Owner
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8133 +/- ##
==========================================
- Coverage 92.02% 92.02% -0.01%
==========================================
Files 760 760
Lines 77394 77394
Branches 23392 23391 -1
==========================================
- Hits 71225 71221 -4
Misses 5061 5061
- Partials 1108 1112 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/settings/autonomy.tsandsrc/review/guardrail-config.tsare now 5-line chore(review): converge 9 hand-duplicated src/review/ files onto their @loopover/engine shims #6203 re-export shims — the real, substantive logic lives at the correspondingpackages/loopover-enginepaths instead. Neither real path was listed inENGINE_DECISION_GUARDRAIL_GLOBS, so a PR editing the autonomy deny-by-default dial, or editingENGINE_DECISION_GUARDRAIL_GLOBS/DEFAULT_HARD_GUARDRAIL_GLOBSitself to quietly remove entries, touched only the real engine-package file and never tripped the guardrail hold it should have.Validation
npm run typecheck— clean.npx vitest run test/unit/guardrail-config.test.ts test/unit/change-guardrail.test.ts— 29/29 passing, including two new cases: both real engine-package paths are classified as guardrail-protected viaisGuardrailHit/DEFAULT_HARD_GUARDRAIL_GLOBS(not just present in the array — actually exercised through the real matching function), and both pre-migration shim paths still guard too (additive, neither replaces the other).packages/loopover-engine(npm run build) before testing, sincesrc/review/guardrail-config.tsre-exports the compiled engine dist output.