fix(review): page fetchFallbackArtifactShots artifacts-list read past 100 artifacts

[RealDiligent]

Summary

• Closes fetchFallbackArtifactShots doesn't paginate the artifacts-list read, unlike its sibling reads in the same visual-capture subsystem #8014
• fetchFallbackArtifactShots (src/review/visual/actions-fallback.ts) read only page 1 of GET /repos/{o}/{r}/actions/runs/{runId}/artifacts?per_page=100 and .find()'d the fallback artifact there. If a run attaches >100 artifacts, the target silently falls off page 1 and the function returned [] exactly as if no artifact existed — the same silent-truncation failure mode preview-url.ts documents and was hardened against in findPreviewUrlFromChecks doesn't paginate check-runs, unlike its sibling functions in the same file #7779/getLatestDeploymentStatus doesn't paginate deployments/statuses reads, unlike its siblings in the same file #7805.
• Fix: walk the Link: rel="next" pages, mirroring preview-url.ts's bounded findAcrossPages walker (the required pattern from the issue): page 1's request stays byte-identical to the pre-pagination read, the &page=N cursor is appended for page 2+ only, and the walk is bounded to 10 pages (ARTIFACT_LIST_MAX_PAGES, same bound as PREVIEW_LIST_MAX_PAGES / PR_DETAIL_MAX_PAGES / MAX_WORKFLOW_RUN_LIST_PAGES) so a pathological response can never spin.
• No behavior change for runs with ≤100 artifacts: same single request, same degrade-to-[] contract on any failure.

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Ran the targeted suites for every test file exercising this module instead of the full sharded run: vitest run test/unit/actions-fallback.test.ts test/unit/actions-fallback-webhook.test.ts test/unit/visual-capture.test.ts — 234 tests green — plus vitest run --coverage test/unit/actions-fallback.test.ts: every changed line and branch in actions-fallback.ts is covered (the only uncovered lines in the file, 259–260, are pre-existing inflateRawRaw internals untouched by this diff). actionlint/workers/mcp/ui checks are untouched surfaces (no workflow, worker, MCP, or UI files changed); CI runs them all.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — backend-only change (no UI, docs, or extension surface touched).

Notes

• Tests added (all in the existing fetchFallbackArtifactShots describe block, reusing its stubSequence mock pattern): target artifact found on page 2 with the page-1 request asserted byte-identical and the page-2 request asserted to carry &page=2; the 10-page bound under an always-rel="next" Link header (asserts exactly 10 list calls); no second fetch when the Link header lacks rel="next"; and a valid-JSON-but-no-artifacts-array page.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-22 14:32:31 UTC}

2 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This fixes a real silent-truncation bug: fetchFallbackArtifactShots previously read only page 1 of the artifacts list, so a run with >100 artifacts could push the target artifact off page 1 and the function would return [] as if no artifact existed. The fix walks Link: rel="next" pages bounded to 10 (ARTIFACT_LIST_MAX_PAGES), keeps page 1's URL byte-identical to the pre-fix request, and mirrors preview-url.ts's existing findAcrossPages pattern. Tests cover the multi-page-find case, the page-bound stop, the no-next-link stop, and a malformed-payload page — all exercising the real code path with realistic mocked Link headers and payloads.

Nits — 3 non-blocking

• hasNextArtifactPage's regex `/rel="next"/` would also match a malformed value like `rel="prev-next"` since it isn't anchored to the full param, though GitHub's actual Link header format makes this practically unreachable (src/review/visual/actions-fallback.ts hasNextArtifactPage).
• The loop reassigns `artifact` across iterations but never resets it to undefined between pages, which is harmless here since it breaks immediately on a match, but worth a comment if the loop body ever grows more page-processing logic (src/review/visual/actions-fallback.ts fetchFallbackArtifactShots).
• Consider extracting the per-page fetch+parse block into a small helper mirroring preview-url.ts's findAcrossPages more literally, since the two modules now duplicate near-identical pagination-walking logic (src/review/visual/actions-fallback.ts, preview-url.ts).

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8014
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 378 registered-repo PR(s), 159 merged, 34 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 378 PR(s), 34 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff replaces the single-page artifact-list fetch with a bounded pagination walker mirroring preview-url.ts's Link-header approach, preserving the byte-identical page-1 request and adding tests for multi-page discovery, the page bound, and the ≤100-artifact single-page case.

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, JavaScript, Ruby, Svelte, TypeScript, Markdown, MDX
• Official Gittensor activity: 378 PR(s), 34 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.