docs(miner): document and load-test shared store concurrency model (#4942) - #8003
Closed
andriypolanski wants to merge 2 commits into
Closed
docs(miner): document and load-test shared store concurrency model (#4942)#8003andriypolanski wants to merge 2 commits into
andriypolanski wants to merge 2 commits into
Conversation
…SONbored#4942) After JSONbored#7175's SqliteDriver seam, state the shared-backend concurrency guarantees (and non-guarantees) explicitly, and add a correctness load suite split across three coverage-hitting test files so scoped CI shards each emit non-empty lcov under --coverage.all=false (the JSONbored#8002 failure). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…JSONbored#4942) Keep only the three coverage-hitting split test files so scoped --coverage.all=false shards each produce non-empty lcov (closes the Co-authored-by: Cursor <cursoragent@cursor.com> JSONbored#8002 empty-shard failure mode).
Contributor
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqliteDriverseam that model needed an explicit shared-service restatement (Re-evaluate the local concurrency model for a shared-service context #4942).lib/*.tsso each scoped CI shard emits non-emptycoverage/lcov.infounder--coverage.all=false.Closes #4942
Change
packages/loopover-miner/docs/ams-shared-store-concurrency-model.md: what SQLiteBEGIN IMMEDIATE/busy_timeout, minercreateD1Adapter.batch, and ORBcreatePgAdapter(READ COMMITTED) guarantee — and what they do not. Contrastsinstallation-concurrency-admission/mapWithConcurrency. Notes control-plane one-DB-per-tenant isolation.operations-runbook.mdandams-storage-abstraction-research.md.miner-shared-store-concurrency-cap.test.ts— cross-processclaimIssueWithinCap(cap=1 → exactly one active row)miner-shared-store-concurrency-adapter.test.ts— 32× concurrentUPDATE … SET n = n + 1viacreateD1Adapter.batch; naive RMW pins the documented lost-update non-guarantee; optional Postgres whenPG_TEST_URLis setminer-shared-store-concurrency-doc.test.ts— doc assertions + local-store smoke openminer-operations-runbook.test.ts— also opens a local store so a shard that only selects it still produces lcovValidation
git diff --checkclean.PG_TEST_URL).build:minerpresent, adapter suite coverage hitslocal-store.ts/store-db-adapter.tsincoverage/lcov.info.UI Evidence
N/A — documentation + concurrency correctness tests only.
Made with Cursor