feat(orb): gate APR repo-transfer on trusted idea completion

[jsdevninja]

Summary

• Closes Decide policy for when an APR repo-transfer offer is surfaced to a customer (deferred from #7638) #7742: customer-request-only APR repo transfer after idea completion (Design spec: idea-completion determination + customer-facing status for APR (no GitHub UI exposure) #7591 signal), wrapping existing initiateAprRepoTransfer — no automatic or proactive offer.
• Fixes Superagent P1 from feat(orb): gate APR repo-transfer requests on idea completion #8000: ideaComplete is not accepted from the request body. loadAprIdeaCompletion is a fail-closed server-side lookup (returns incomplete until Design spec: idea-completion determination + customer-facing status for APR (no GitHub UI exposure) #7591/Persisted, identity-bound idea-submission record — blocked on identity/consent decision #7664 persist completion); smuggling ideaComplete in the body is rejected by a .strict() schema (400).
• Exposes POST /v1/loop/request-apr-transfer — 202 initiated, 409 idea not complete, 502 GitHub rejected, 400 invalid body.

Test plan

• Unit: eligibility; request uses trusted lookup; incomplete never calls initiate; injectable complete path initiates / surfaces failure
• Route: 409 under default fail-closed lookup; 400 on smuggled ideaComplete; 202/502 when lookup mocked complete; optional ideaId forwarded; no wallet/hotkey/trust-score leakage
• npm run typecheck
• Focused vitest: orb-apr-repo-transfer + routes-request-apr-transfer (21 passing)

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-22 06:07:06 UTC}

5 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR adds a customer-facing APR transfer-request endpoint gated on a fail-closed, server-side idea-completion lookup (currently hardcoded to always return incomplete), with a `.strict()` Zod schema that rejects any attempt to smuggle `ideaComplete` in the request body — directly closing the #8000 Superagent P1. The implementation is correct: `requestAprRepoTransfer` never calls `initiateAprRepoTransfer` (and thus never contacts GitHub) unless the trusted lookup reports complete, and the route correctly maps rejected/failed/initiated to 409/502/202. Test coverage is thorough (eligibility, gate short-circuiting, route status codes, schema strictness, no-leak assertions) and traces the real path rather than a fabricated one.

Nits — 5 non-blocking

• src/orb/apr-idea-completion.ts: the stub always returns `{ ideaComplete: false }`, which means `requestAprRepoTransfer`'s `initiated`/`failed` branches (and the 202/502 route paths) are only exercisable today via the injectable `loadCompletion` test hook, not the real default path — worth a one-line comment in the route test file noting this is intentionally mocked until Persisted, identity-bound idea-submission record — blocked on identity/consent decision #7664 lands.
• src/api/routes.ts:3743-3755: consider extracting the repeated magic HTTP status literals (400/409/502/202) into named constants for consistency with other route handlers in this large file, though this is purely stylistic.
• src/orb/apr-repo-transfer.ts: `RequestAprRepoTransferInput.ideaId` is accepted and forwarded to the lookup but never validated against anything server-side yet (fine for now since the lookup itself ignores it, but worth flagging when Persisted, identity-bound idea-submission record — blocked on identity/consent decision #7664 lands so `ideaId` can't be used to probe for a completion record that doesn't belong to the caller's repo).
• Consider adding a brief JSDoc note on `AprIdeaCompletionLookupInput.ideaId` clarifying it's currently unused by the lookup body, to avoid confusion once Persisted, identity-bound idea-submission record — blocked on identity/consent decision #7664 wires it up.
• The `requestAprTransferSchema` and its route are well-isolated; when Persisted, identity-bound idea-submission record — blocked on identity/consent decision #7664 lands, make sure the same `.strict()` shape is preserved so `ideaComplete` remains permanently unacceptable from the body.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7742
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 210 registered-repo PR(s), 132 merged, 37 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	jsdevninja; Gittensor profile; 210 PR(s), 37 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff adds a customer-request-only requestAprRepoTransfer path and REST route gated on a server-side loadAprIdeaCompletion signal (fail-closed until #7591/#7664 persist it), rejects client-supplied ideaComplete via a strict schema, ignores plan/tier fields, and includes tests confirming no auto-offer path exists, matching the deliverables in the issue.

Review context

• Author: jsdevninja
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: JavaScript, Swift, C, CSS, MDX, Python, TypeScript, Vue
• Official Gittensor activity: 210 PR(s), 37 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.79%. Comparing base (24ddd19) to head (1faaa18).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8001      +/-   ##
==========================================
- Coverage   91.92%   89.79%   -2.14%     
==========================================
  Files         740       97     -643     
  Lines       75933    24344   -51589     
  Branches    23040     4579   -18461     
==========================================
- Hits        69803    21860   -47943     
+ Misses       5037     2214    -2823     
+ Partials     1093      270     -823     

Flag	Coverage Δ
shard-1	28.19% <100.00%> (-30.23%)	⬇️
shard-2	44.25% <9.52%> (-8.25%)	⬇️
shard-3	72.00% <9.52%> (+22.66%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/api/routes.ts	95.18% <100.00%> (+0.01%)	⬆️
src/orb/apr-idea-completion.ts	100.00% <100.00%> (ø)
src/orb/apr-repo-transfer.ts	100.00% <100.00%> (ø)

... and 644 files with indirect coverage changes