Skip to content

feat(mcp): register loopover_list_notifications as a local stdio tool (#7761) - #7956

Closed
kai392 wants to merge 1 commit into
JSONbored:mainfrom
kai392:feat/7761-stdio-list-notifications
Closed

feat(mcp): register loopover_list_notifications as a local stdio tool (#7761)#7956
kai392 wants to merge 1 commit into
JSONbored:mainfrom
kai392:feat/7761-stdio-list-notifications

Conversation

@kai392

@kai392 kai392 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Registers loopover_list_notifications as a local stdio MCP tool (89 → 90), mirroring the existing remote tool + notifications CLI.
  • Reuses getNotificationsGET /v1/contributors/:login/notifications (no duplicated HTTP).
  • Handler is branch-free (no ?? / ?. / ternaries) to keep codecov/patch at ~100% after Register loopover_watch_issues as a local stdio MCP tool #7763 partials failures.

Closes #7761

Test plan

  • build:mcp + typecheck + branding-drift:check
  • vitest coverage: mcp-cli-list-notifications-tool, mcp-tool-rename-aliases (3 executable patch lines, all hit)
  • CI green including codecov/patch

@kai392
kai392 requested a review from JSONbored as a code owner July 21, 2026 22:27
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@002a864). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7956   +/-   ##
=======================================
  Coverage        ?   11.42%           
=======================================
  Files           ?        1           
  Lines           ?     2188           
  Branches        ?      838           
=======================================
  Hits            ?      250           
  Misses          ?     1920           
  Partials        ?       18           
Flag Coverage Δ
shard-1 11.42% <100.00%> (?)
shard-2 0.00% <0.00%> (?)
shard-3 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-mcp/bin/loopover-mcp.ts 11.42% <100.00%> (ø)

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 21, 2026
@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-21 22:48:07 UTC

3 files · 1 AI reviewer · no blockers · CI green · dirty

⏸️ Suggested Action - Manual Review

Review summary
This registers `loopover_list_notifications` as a local stdio MCP tool, delegating to the existing `getNotifications` helper (used by the CLI `notifications` command and remote tool) and following the same `registerStdioTool` pattern as neighboring entries. The tool-count bump (89→90) is threaded consistently through `mcp-tool-rename-aliases.test.ts`, and a new in-process test exercises registration, request URL, and response shape. The change is narrow, closes the linked #7761, and matches the file's existing conventions (loose `any` typing, comment-annotated tool descriptors).

Nits — 5 non-blocking
  • packages/loopover-mcp/bin/loopover-mcp.ts:2320 — the handler param is typed `any`, but that matches every other `registerStdioTool` handler already in this file, so it's consistent rather than a regression; just flagging per the external scan.
  • test/unit/mcp-cli-list-notifications-tool.test.ts:33 — `LOOPOVER_API_TOKEN = "in-process-token"` is a hardcoded test fixture value, not a real credential; the secret-scan hit here looks like a false positive but worth a quick human glance to confirm no real token got pasted in.
  • I can't see the definitions of `getNotifications`, `loginShape`, or `stdioToolDescription` in the provided file excerpt (they're in the omitted middle) — worth confirming they're the same helpers the remote tool and `notifications` CLI already use, as the PR description claims, rather than new duplicates.
  • If `getNotifications` doesn't already dedupe path-building for `/v1/contributors/:login/notifications`, consider extracting a shared constant since both the remote tool and this stdio twin now reference the same route.
  • Possible secret-shaped assignment in the diff (generic_secret_assignment) — Verify the value is not a real credential.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7761
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 78 registered-repo PR(s), 44 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kai392; Gittensor profile; 78 PR(s), 0 issue(s).
Improvement ✅ Minor risk: clean · value: minor
Linked issue satisfaction

Addressed
The PR adds a registerStdioTool block for loopover_list_notifications following the exact pattern of its siblings, reuses the existing getNotifications call (no duplicated HTTP), and uses the centralized stdioToolDescription lookup, with accompanying test coverage and updated tool-count assertions.

Review context
  • Author: kai392
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: JavaScript, Kotlin, Perl, TypeScript, Vue
  • Official Gittensor activity: 78 PR(s), 0 issue(s).
  • Related work: Titles/paths share 9 meaningful terms. (PR #7955)
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@loopover-orb loopover-orb Bot closed this Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register loopover_list_notifications as a local stdio MCP tool

2 participants