fix(ui): restore gittensory_ legacy localStorage keys destroyed by rebrand (#7782) - #7908
fix(ui): restore gittensory_ legacy localStorage keys destroyed by rebrand (#7782)#7908kai392 wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…brand (JSONbored#7782) Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-21 17:11:24 UTC
Review summary Nits — 5 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-code)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |


Summary
The Phase-5 blanket
gittensory→loopoverrename also rewrote two intentional pre-rebrandlegacyKeystring literals, sokey === legacyKeyanduseLocalStorage's migration path became a no-op (#7782). A maintainer who dismissed the onboarding preview or opted into notifications before the rebrand silently lost that preference.Restore the distinct
gittensory_...legacy literals (matching the surviving pattern intry-it.tsx) and add a regression test per component that seeds the legacy key and asserts migration + UI state.Visual note: string-literal / storage-migration only — at-rest UI is unchanged; before/after shots are pixel-identical by design.
Closes #7782
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lint(eslint on the four touched files)npm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
apps/loopover-ui(no src 99% patch gate). Ran package-local prettier + eslint + vitest ononboarding-preview-card.test.tsxandnotification-readiness-card.test.tsx(11/11 pass). Root workers/MCP/OpenAPI are unrelated.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Dark theme only (loopover-ui has no light theme). Annotated cards call out the restored
gittensory_→loopover_key pairs. Before and after are pixel-identical — the fix is storage-key migration only.Notes