feat(control-plane): tenant provision orchestration with reliable deprovision - #7544
feat(control-plane): tenant provision orchestration with reliable deprovision#7544jsdevninja wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7544 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 720 720
Lines 75733 75733
Branches 22547 22548 +1
=======================================
Hits 67008 67008
Misses 7679 7679
Partials 1046 1046
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Superseded by #7543, which already merged #7524 into main. Rebase onto current Closing this PR rather than force-resolving a duplicate package on top of the merged implementation. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🛑 LoopOver review result - reject/close recommendedReview updated: 2026-07-20 21:42:27 UTC
Review summary Nits — 1 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR; No linked issue detected). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
control-plane/with product-agnosticprovisionTenant()/deprovisionTenant()behind an injectableTenantProvisioningDriverand fake/in-memory driver (no live Cloudflare/Postgres SDKs).#7174-shapedTenantSecretBrokerseam.deprovisionTenantalways callsrevokeSecrets/destroyDatabase/destroyContainer— whenprovisionedhandles are omitted, IDs are left undefined so the driver tears down by tenant (lost-handle / restart safe). Regression tests assert the driver is actually invoked and live resources are removed.Closes #7524
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragenpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
control-plane/package (outside root Codecovcoverage.include, same asreview-enrichment/). Rannpm --prefix control-plane test(14 pass), including regression coverage for the feat(control-plane): add tenant provision orchestration with fake driver #7539 deprovision defect.control-plane:testis wired intotest:ci.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — control-plane orchestration library only; no visible UI.
Notes
options.provisionedwas omitted.coding-agent-driver.tsfake-driver seam;review-enrichment/package skeleton;src/orb/broker.ts#7174secret_type.Made with Cursor