chore(mcp): convert bin/loopover-mcp.js to TypeScript (Phase 3 of #7291) - #7509
Conversation
…Nbored#7291) Single-file 1:1 conversion through tsc, with bin sourcemap stripped so the shipped JS stays under LoopOver'\''s 512KB patch-less secrets-scan fetch cap (the failure mode that closed JSONbored#7431). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7509 +/- ##
==========================================
- Coverage 91.43% 88.47% -2.97%
==========================================
Files 718 719 +1
Lines 73214 75664 +2450
Branches 21692 22523 +831
==========================================
Hits 66944 66944
- Misses 5227 7677 +2450
Partials 1043 1043
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-20 18:26:10 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
bin/loopover-mcp.js→bin/loopover-mcp.ts(not a split). Natural seams exist, but splitting is a separate refactor; this PR only routes the CLI throughtscso@loopover/mcpis 100% compiler-verified TypeScript and closes Phase 3 of chore(mcp): migrate packages/loopover-mcp from plain .js to real TypeScript #7291 / chore(mcp): convert bin/loopover-mcp.js to TypeScript (Phase 3 of #7291) #7330.anywhere plain JS had no types), matching Phase 1/2 scope — not a type-safety redesign.tscemitsbin/loopover-mcp.js, thenscripts/strip-bin-sourcemap.mjsremoves the inline sourcemap from bin only. Without that strip, the shipped JS (~635KB) exceeds LoopOver's 512KB patch-less secrets-scan fetch cap — the hard blocker that closed #7431. Lib modules keep inline maps for coverage remap; bin is subprocess-only tested so v8 never remaps it.!bin/**/*.tsinpackage.jsonfiles(mirror miner /!lib/**/*.ts); Windows-safefileURLToPathincheck-syntax.mjs; branding-drift baseline updated for the new.tspath.Closes #7330.
Test plan
npx tsc -p packages/loopover-mcp/tsconfig.json --noEmit— 0 errorsnpm run build --workspace @loopover/mcp(tsc + strip + check-syntax) — passes;bin/loopover-mcp.js~319KB (under 512KB)loopover-mcp --version/--helpunchanged smokemcp-cli-help,mcp-cli-completion-spec,worker-entry-boundarynode scripts/check-branding-drift.mjs— ok after baseline updateNotes vs #7431
Same 1:1 approach as the closed attempt; the intentional delta is stripping the bin inline sourcemap so secrets-scan can fetch the compiled JS under the 512KB cap.