Skip to content

docs(ci): fix stale vitest.config.ts comment about lib/cli-error.js coverage - #7472

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:docs/vitest-config-stale-cli-error-comment-7435
Jul 20, 2026
Merged

docs(ci): fix stale vitest.config.ts comment about lib/cli-error.js coverage#7472
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:docs/vitest-config-stale-cli-error-comment-7435

Conversation

@lourincedaging0-commits

Copy link
Copy Markdown
Contributor

Closes #7435

What

vitest.config.ts's comment above the packages/loopover-mcp/lib/**/*.js coverage.include entry claimed lib/cli-error.js had no in-process test. That was true when written (80b59c64), but #7409 (merged 2026-07-20) added test/unit/mcp-cli-error.test.ts, which imports cli-error.js in-process and exercises all three of its exports. The comment was never updated, so it now tells a contributor something false about the package's test-coverage state.

This corrects the sentence to reflect that all five of the package's lib/ files (format-table/local-branch/redact-local-path/telemetry/cli-error) now have in-process tests.

Scope

  • Comment-only — no coverage.include/coverage.exclude glob or any other behavior changed (verified: the diff is 4 comment lines).
  • Nothing to regression-test (no executable code path affected).

…overage

The comment above the packages/loopover-mcp/lib/**/*.js coverage.include entry said
lib/cli-error.js had no in-process test. That stopped being true when JSONbored#7409 added
test/unit/mcp-cli-error.test.ts, which imports cli-error.js in-process and exercises
all three of its exports. Correct the sentence so it reflects that all five of the
package's lib/ files now have in-process tests. Comment-only; no glob or behavior change.

Closes JSONbored#7435
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.36%. Comparing base (fbd1cba) to head (be2d97c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7472   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         717      717           
  Lines       73016    73016           
  Branches    21628    21631    +3     
=======================================
  Hits        66713    66713           
  Misses       5265     5265           
  Partials     1038     1038           
Flag Coverage Δ
shard-1 34.16% <ø> (ø)
shard-2 39.31% <ø> (ø)
shard-3 32.62% <ø> (+0.01%) ⬆️
shard-4 39.53% <ø> (ø)
shard-5 36.58% <ø> (ø)
shard-6 34.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 20, 2026
@loopover-orb

loopover-orb Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-20 11:34:41 UTC

1 file · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a comment-only correction in vitest.config.ts updating a stale coverage note: it now correctly states all 5 packages/loopover-mcp/lib files (including cli-error.js) have in-process test coverage as of #7409, rather than the outdated claim that cli-error.js had none. The diff is purely a comment change with no effect on coverage.include/exclude globs or any executable behavior, and the referenced test/unit/mcp-cli-error.test.ts landing in #7409 is a verifiable, plausible historical event. No test changes are needed since nothing executable changed.

Nits — 3 non-blocking

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7435
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 97 registered-repo PR(s), 46 merged, 5 issue(s).
Contributor context ✅ Confirmed Gittensor contributor lourincedaging0-commits; Gittensor profile; 97 PR(s), 5 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Addressed
The diff replaces the stale sentence claiming lib/cli-error.js has no in-process test with an accurate statement that all 5 lib files including cli-error.js now have in-process tests, citing PR #7409, and touches only the comment block without altering any include/exclude globs.

Review context
  • Author: lourincedaging0-commits
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: HTML
  • Official Gittensor activity: 97 PR(s), 5 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 582fc3a into JSONbored:main Jul 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(ci): fix stale vitest.config.ts comment claiming lib/cli-error.js has no in-process test

1 participant