Skip to content

fix(miner-ui): give ChatComposer's textarea an accessible name #7465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 20, 2026
Merged

fix(miner-ui): give ChatComposer's textarea an accessible name #7465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/loopover-miner-ui/src/chat-composer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ const MAX_HEIGHT_PX = 160;
function setup(props: Partial<Parameters<typeof ChatComposer>[0]> = {}) {
const onSubmit = vi.fn();
render(<ChatComposer onSubmit={onSubmit} {...props} />);
const textarea = screen.getByRole("textbox") as HTMLTextAreaElement;
// #7440: query by accessible name so this pins that the composer's textarea actually has one.
const textarea = screen.getByRole("textbox", { name: /chat message/i }) as HTMLTextAreaElement;
return { onSubmit, textarea, button: screen.getByRole("button", { name: /send/i }) };
}

Expand Down
4 changes: 4 additions & 0 deletions apps/loopover-miner-ui/src/components/chat-composer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ export function ChatComposer({
<div className="flex items-end gap-2">
<Textarea
ref={textareaRef}
// #7440: the ui-kit Textarea is a bare native <textarea> with no label of its own, and a
// placeholder is not a reliable accessible name (it vanishes once typing starts and is exposed
// to AT inconsistently). Give it a stable, purpose-describing name independent of `placeholder`.
aria-label="Chat message"
value={value}
onChange={(event) => setValue(event.target.value)}
onKeyDown={(event) => {
Expand Down
Loading