chore(miner): migrate batch 2.2 utility modules to TypeScript - #7338
chore(miner): migrate batch 2.2 utility modules to TypeScript#7338RealDiligent wants to merge 1 commit into
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Closes JSONbored#7301. Convert eight leaf-most lib modules to real .ts with in-place emit; hand-maintained .d.ts siblings are now tsc-generated. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7338 +/- ##
==========================================
+ Coverage 91.03% 91.89% +0.86%
==========================================
Files 714 631 -83
Lines 72118 51553 -20565
Branches 19232 15866 -3366
==========================================
- Hits 65651 47374 -18277
+ Misses 5427 3239 -2188
+ Partials 1040 940 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Caution 🛑 LoopOver review result - reject/close recommendedReview updated: 2026-07-19 18:36:40 UTC
Review summary Blockers
Nits — 6 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentCI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionPartially addressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, codecov/patch, validate-tests-merge); AI reviewers agree on a likely critical defect: CI already reports `codecov/patch` failing at 87.60% (target 99%) with zero test lines added across 3,709 new/changed source lines in 24 files — per this repo's coverage bar, that needs to be closed (either by demonstrating the existing suite already exercises the compiled `.js` output paths for every branch, or by adding coverage) before this is merge-ready.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Closes #7301
Summary
packages/loopover-miner/libmodules from plain.jsto real, compiler-verified TypeScript:deployment-docs-audit,chat-discover-attempt-actions,update-check,init-wizard,deny-hook-synthesis,calibration-run,manage-poll,orb-export.lib/foo.tscompiles tolib/foo.jsnext to it; no import-path changes for any consumer)..d.tssibling is nowtsc-generated instead of hand-written.Scope checklist
.js/.d.tsoutput)tsconfig.jsonchanges needed (existingincludeglob picks up new.tsfiles automatically)Validation checklist
npx tsc -p packages/loopover-miner/tsconfig.jsonpasses clean;node --checkon all 8 compiled outputspath.join/0o600); Linux CI is the gateSafety checklist
site/,CNAME, or**/lovable/**Made with Cursor