chore(miner): migrate batch 2.1 utility modules to TypeScript - #7320
Conversation
Converts env-file-indirection, deny-check, cli, chat-action-dispatch, ams-health-server, replay-task-bridge, chat-governor-actions, and chat-portfolio-actions from plain .js to real, compiler-verified TypeScript, following the in-place-emit pattern the Phase 1 build pipeline (JSONbored#7299) already wired up. Each file's hand-maintained .d.ts sibling is now tsc-generated instead. No behavior change; existing tests pass unmodified. Closes JSONbored#7300
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-19 16:25:22 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #7300
Summary
packages/loopover-miner/libmodules from plain.jsto real, compiler-verified TypeScript:env-file-indirection,deny-check,cli,chat-action-dispatch,ams-health-server,replay-task-bridge,chat-governor-actions,chat-portfolio-actions.lib/foo.tscompiles tolib/foo.jsnext to it; no import-path changes for any consumer)..d.tssibling is nowtsc-generated instead of hand-written.buildLeakageContextFromSnapshot'sknownCommitShasarray keepsundefinedentries for malformed commits (never filtered), andbuildReplayCandidateFromSnapshotnulls out non-string identity fields rather than leaving themundefined.Scope checklist
.js/.d.tsoutput)tsconfig.jsonchanges needed (existingincludeglob picks up new.tsfiles automatically)Validation checklist
npm run build --workspace @loopover/miner(tsc +node --checkon every compiled output) passes cleannpm run typecheck(repo-wide) passes cleanminer-env-file-indirection,miner-cli-deny-check,miner-cli,miner-chat-action-dispatch,miner-ams-health-server,miner-replay-task-bridge,miner-chat-governor-actions,miner-chat-portfolio-actions(107 tests total)Safety checklist
site/,CNAME, or**/lovable/**