fix(miner): add policy-doc-cache to doctor and migrate store lists (#7238) - #7263
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7263 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 704 704
Lines 69506 69506
Branches 18912 18912
=======================================
Hits 65210 65210
Misses 3302 3302
Partials 994 994
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-19 11:18:17 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
packages/loopover-miner/lib/policy-doc-cache.jsis a durable local SQLite store (opened throughresolveLocalStoreDbPath, like every other miner store), but it was missing from the two lists that aremeant to cover every such store:
status.js'sstoreIntegrityChecks—doctor's per-storePRAGMA integrity_checksweep, whose owncomment says to keep it in sync with migrate-cli's
STORES. A corruptedpolicy-doc-cache.sqlite3wentunflagged by
doctor.migrate-cli.js'sSTORES— the migrate sweep. The store's schema was never brought up to date bymigrate.This adds
policy-doc-cacheto both, strictly appended afterpolicy-verdict-cache(its distinct sibling)without reordering or touching any of the existing 13 entries.
Closes #7238
Scope
site//CNAME/lovable; no new dependency.Closes #7238).Validation
git diff --checknpm run typecheck(root — clean)npm run test:coverage— 100% of the changed lines covered. The existing doctor/migrate parity tests(which assert the exact store list, in order) are updated from 13 to 14 entries and pass; the migrate
test's
STORE_NAMESand the doctor integrity-list assertion now includepolicy-doc-cache.npm run build:miner(node --checkon both files passes).If any required check was skipped, explain why:
packages/loopover-miner/lib/**; CI runs the full suite.Safety