Skip to content

chore: remove accidental self-referential node_modules symlink - #722

Merged
JSONbored merged 1 commit into
mainfrom
chore/remove-circular-node-modules-symlink
Jun 14, 2026
Merged

chore: remove accidental self-referential node_modules symlink#722
JSONbored merged 1 commit into
mainfrom
chore/remove-circular-node-modules-symlink

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Problem

A node_modules symlink pointing at its own absolute path (/Users/.../gittensory/node_modules) was accidentally committed in #680 (mode 120000). It shadows the real install with a circular link, so node_modules/.bin/* resolution fails on a fresh checkout with too many levels of symbolic links — breaking local tsc/vitest until the symlink is cleared by hand.

CI is unaffected because npm ci removes node_modules before installing, which masked the issue.

Fix

git rm --cached node_modules — untrack the symlink blob. The directory is already covered by .gitignore (node_modules/), so the real install stays ignored. No source, runtime, or deploy impact.

Verification

  • git ls-tree HEAD node_modules → empty (no longer tracked)
  • Real node_modules/.bin/tsc present and functional; npm run typecheck clean

A `node_modules` symlink pointing at its own absolute path was
accidentally committed in #680, shadowing the real install with a
circular link ("too many levels of symbolic links") that breaks
node_modules/.bin/* resolution on fresh checkouts. CI is unaffected
because `npm ci` removes node_modules before installing, but local
tooling (tsc, vitest) fails until the symlink is cleared.

The directory is already covered by .gitignore (node_modules/), so
untracking the symlink blob restores correct behavior with no
runtime or deploy impact.
@ghost

ghost commented Jun 14, 2026

Copy link
Copy Markdown

gittensory · advisory review

Reviewed 1 changed file(s) — two independent AI reviewers.

Suggested action:Safe to merge — both reviewers found no blocking issues.

Reviewer A · gpt-oss-120b — recommends ✅ merge
This PR removes an accidental self‑referential node_modules symlink file from the repo root, cleaning up a potential source of recursive path issues. The change is isolated, has no code modifications, and poses minimal risk.

Suggestions

  • Run the CI test suite after merging to confirm no build steps unexpectedly relied on the removed symlink.

Worth double-checking

  • If any custom scripts or tooling referenced the stray symlink, they may now fail.

Reviewer B · nemotron-3-120b-a12b — recommends ✅ merge
The PR removes an accidentally committed node_modules symlink that pointed to a local absolute path. This is a safe housekeeping change as node_modules should never be committed to version control. The change is minor, low-risk, and aligns with standard repository hygiene.

No blocking issues spotted.

@ghost ghost added the gittensory-review label Jun 14, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@ghost

ghost commented Jun 14, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #722 is no longer open. No action.

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 14, 2026
@JSONbored
JSONbored merged commit 66a4f65 into main Jun 14, 2026
10 checks passed
@JSONbored
JSONbored deleted the chore/remove-circular-node-modules-symlink branch June 14, 2026 14:37
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant