chore: remove accidental self-referential node_modules symlink - #722
Conversation
A `node_modules` symlink pointing at its own absolute path was accidentally committed in #680, shadowing the real install with a circular link ("too many levels of symbolic links") that breaks node_modules/.bin/* resolution on fresh checkouts. CI is unaffected because `npm ci` removes node_modules before installing, but local tooling (tsc, vitest) fails until the symlink is cleared. The directory is already covered by .gitignore (node_modules/), so untracking the symlink blob restores correct behavior with no runtime or deploy impact.
|
gittensory · advisory review Reviewed 1 changed file(s) — two independent AI reviewers. Suggested action: ✅ Safe to merge — both reviewers found no blocking issues. Reviewer A · Suggestions
Worth double-checking
Reviewer B · No blocking issues spotted. |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Problem
A
node_modulessymlink pointing at its own absolute path (/Users/.../gittensory/node_modules) was accidentally committed in #680 (mode120000). It shadows the real install with a circular link, sonode_modules/.bin/*resolution fails on a fresh checkout withtoo many levels of symbolic links— breaking localtsc/vitestuntil the symlink is cleared by hand.CI is unaffected because
npm ciremovesnode_modulesbefore installing, which masked the issue.Fix
git rm --cached node_modules— untrack the symlink blob. The directory is already covered by.gitignore(node_modules/), so the real install stays ignored. No source, runtime, or deploy impact.Verification
git ls-tree HEAD node_modules→ empty (no longer tracked)node_modules/.bin/tscpresent and functional;npm run typecheckclean