Skip to content

Fix: persist and expose repository gatePack setting #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 2 commits into from
Jun 14, 2026
Merged

Fix: persist and expose repository gatePack setting #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7e2fde
fix: persist repository gate pack settings
JSONbored Jun 14, 2026
ed602db
Merge branch 'main' into codex/fix-gatepack-settings-write-vulnerability
JSONbored Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/api/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,7 @@ const repositorySettingsSchema = z.object({
checkRunMode: z.enum(["off", "enabled"]).default("off"),
checkRunDetailLevel: z.enum(["minimal", "standard", "deep"]).default("standard"),
gateCheckMode: z.enum(["off", "enabled"]).default("off"),
gatePack: z.enum(["gittensor", "oss-anti-slop"]).default("gittensor"),
linkedIssueGateMode: z.enum(["off", "advisory", "block"]).default("advisory"),
duplicatePrGateMode: z.enum(["off", "advisory", "block"]).default("block"),
qualityGateMode: z.enum(["off", "advisory", "block"]).default("advisory"),
Expand Down Expand Up @@ -2602,6 +2603,7 @@ export function createApp() {
checkRunMode: parsed.data.checkRunMode,
checkRunDetailLevel: parsed.data.checkRunDetailLevel,
gateCheckMode: parsed.data.gateCheckMode,
gatePack: parsed.data.gatePack,
linkedIssueGateMode: parsed.data.linkedIssueGateMode,
duplicatePrGateMode: parsed.data.duplicatePrGateMode,
qualityGateMode: parsed.data.qualityGateMode,
Expand Down
1 change: 1 addition & 0 deletions src/db/repositories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,7 @@ export async function upsertRepositorySettings(env: Env, settings: Partial<Repos
checkRunMode: resolved.checkRunMode,
checkRunDetailLevel: resolved.checkRunDetailLevel,
gateCheckMode: resolved.gateCheckMode,
gatePack: resolved.gatePack,
linkedIssueGateMode: resolved.linkedIssueGateMode,
duplicatePrGateMode: resolved.duplicatePrGateMode,
qualityGateMode: resolved.qualityGateMode,
Expand Down
4 changes: 3 additions & 1 deletion test/integration/api.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5596,6 +5596,7 @@ describe("api routes", () => {
body: JSON.stringify({
commentMode: "detected_contributors_only",
publicSignalLevel: "minimal",
gatePack: "oss-anti-slop",
commandAuthorization: { default: ["maintainer"], commands: { preflight: ["pr_author"], "queue-summary": ["maintainer", "collaborator"] } },
}),
},
Expand All @@ -5605,12 +5606,13 @@ describe("api routes", () => {
await expect(updated.json()).resolves.toMatchObject({
commentMode: "detected_contributors_only",
publicSignalLevel: "minimal",
gatePack: "oss-anti-slop",
commandAuthorization: { default: ["maintainer"], commands: expect.objectContaining({ preflight: ["pr_author"] }) },
});

const settings = await app.request("/v1/repos/entrius/allways-ui/settings", { headers: apiHeaders(env) }, env);
expect(settings.status).toBe(200);
await expect(settings.json()).resolves.toMatchObject({ commentMode: "detected_contributors_only", commandAuthorization: { commands: expect.objectContaining({ preflight: ["pr_author"] }) } });
await expect(settings.json()).resolves.toMatchObject({ commentMode: "detected_contributors_only", gatePack: "oss-anti-slop", commandAuthorization: { commands: expect.objectContaining({ preflight: ["pr_author"] }) } });

const preview = await app.request(
"/v1/repos/entrius/allways-ui/settings-preview",
Expand Down
2 changes: 2 additions & 0 deletions test/unit/data-spine.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ describe("data spine repositories", () => {
// gatePack (#692) round-trips and defaults to gittensor.
await upsertRepositorySettings(env, { repoFullName: "owner/repo", gatePack: "oss-anti-slop" });
expect((await getRepositorySettings(env, "owner/repo")).gatePack).toBe("oss-anti-slop");
await upsertRepositorySettings(env, { repoFullName: "owner/repo", gatePack: "gittensor", linkedIssueGateMode: "block" });
expect(await getRepositorySettings(env, "owner/repo")).toMatchObject({ gatePack: "gittensor", linkedIssueGateMode: "block" });
await upsertRepositorySettings(env, { repoFullName: "owner/defaultpack" });
expect((await getRepositorySettings(env, "owner/defaultpack")).gatePack).toBe("gittensor");
// slop gate (#530/#532) round-trips and defaults to off.
Expand Down