Skip to content

fix(scripts): scan apps/* workspaces for branding drift - #7117

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-7095
Jul 17, 2026
Merged

fix(scripts): scan apps/* workspaces for branding drift#7117
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-7095

Conversation

@bitfathers94

Copy link
Copy Markdown
Contributor

fix(scripts): scan apps/* workspaces for branding drift

BRANDING_DRIFT_PATHSPECS only covered packages/, so every apps/
workspace was invisible to the check despite the header comment's stated
"each workspace package" scope. package.json declares both apps/* and
packages/* as workspaces, and apps/loopover-ui/src already carries four
legitimate legacy-localStorage-key "gittensory" references -- a new,
unintentional reintroduction anywhere under apps/*/src would ship
silently.

Add apps//src/**/.ts, apps//src/**/.tsx (UI workspaces are TSX-heavy)
and apps//scripts/**/.mjs, mirroring the existing packages/* pathspecs.
The unscoped **/.test.ts / **/.test.tsx excludes already apply, so the
four hits are the real source files only. Regenerate the baseline to
grandfather them at their current count.

Closes #7095

BRANDING_DRIFT_PATHSPECS only covered packages/*, so every apps/*
workspace was invisible to the check despite the header comment's stated
"each workspace package" scope. package.json declares both apps/* and
packages/* as workspaces, and apps/loopover-ui/src already carries four
legitimate legacy-localStorage-key "gittensory" references -- a new,
unintentional reintroduction anywhere under apps/*/src would ship
silently.

Add apps/*/src/**/*.ts, apps/*/src/**/*.tsx (UI workspaces are TSX-heavy)
and apps/*/scripts/**/*.mjs, mirroring the existing packages/* pathspecs.
The unscoped **/*.test.ts / **/*.test.tsx excludes already apply, so the
four hits are the real source files only. Regenerate the baseline to
grandfather them at their current count.

Closes JSONbored#7095
@bitfathers94
bitfathers94 requested a review from JSONbored as a code owner July 17, 2026 22:00
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.98%. Comparing base (8e31375) to head (e23e6cd).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7117      +/-   ##
==========================================
+ Coverage   93.75%   95.98%   +2.22%     
==========================================
  Files         692      609      -83     
  Lines       68809    48145   -20664     
  Branches    18781    15133    -3648     
==========================================
- Hits        64512    46210   -18302     
+ Misses       3302     1118    -2184     
+ Partials      995      817     -178     
Flag Coverage Δ
rees ?
shard-1 43.79% <ø> (ø)
shard-2 36.84% <ø> (ø)
shard-3 33.14% <ø> (ø)
shard-4 34.48% <ø> (ø)
shard-5 32.29% <ø> (-0.01%) ⬇️
shard-6 45.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 83 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 17, 2026
@loopover-orb

loopover-orb Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-17 22:16:16 UTC

3 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR extends BRANDING_DRIFT_PATHSPECS to cover apps/*/src/**/*.ts(x) and apps/*/scripts/**/*.mjs, mirroring the existing packages/* pathspecs, and regenerates the baseline to grandfather the four pre-existing loopover-ui hits. The fix directly addresses the stated gap (apps/* workspaces were invisible to the drift check) and is verified by both a new unit test asserting the pathspecs are passed to exec and an integration-style test proving a new apps/*/src hit is detected as drift. Scope is narrow and well-targeted: pathspec additions, baseline regeneration, and tests, closing #7095.

Nits — 4 non-blocking
  • The new pathspecs omit an apps/*/lib/**/*.ts or apps/*/bin/** entry (unlike packages/*, which has bin/lib/src/scripts) — worth confirming no apps/* workspace has code living outside src/ and scripts/.
  • scripts/check-branding-drift.mjs's header comment block wasn't updated to mention apps/* in its pathspec scope description, though the shorter comment directly above BRANDING_DRIFT_PATHSPECS was updated correctly.
  • Confirm via `ls apps/*/lib apps/*/bin` (or repo knowledge) that no apps/* workspace ships executable code outside src/scripts before considering this scope complete.
  • Consider a follow-up comment noting why apps/* only needs src/scripts (no lib/bin) if that's intentional, to preempt the same question next time packages/* gains a new dir type.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7095
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 0 registered-repo PR(s), 0 merged, 0 issue(s).
Contributor context ℹ️ No public Gittensor match bitfathers94; not a blocker.
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Review context
  • Author: bitfathers94
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Contributor context: Public profile only; not a blocker.
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 8e6d9bf into JSONbored:main Jul 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check-branding-drift.mjs's BRANDING_DRIFT_PATHSPECS excludes every apps/* workspace, including apps/loopover-ui's own live 'gittensory' references

1 participant