fix(scripts): scan apps/* workspaces for branding drift - #7117
Conversation
BRANDING_DRIFT_PATHSPECS only covered packages/*, so every apps/* workspace was invisible to the check despite the header comment's stated "each workspace package" scope. package.json declares both apps/* and packages/* as workspaces, and apps/loopover-ui/src already carries four legitimate legacy-localStorage-key "gittensory" references -- a new, unintentional reintroduction anywhere under apps/*/src would ship silently. Add apps/*/src/**/*.ts, apps/*/src/**/*.tsx (UI workspaces are TSX-heavy) and apps/*/scripts/**/*.mjs, mirroring the existing packages/* pathspecs. The unscoped **/*.test.ts / **/*.test.tsx excludes already apply, so the four hits are the real source files only. Regenerate the baseline to grandfather them at their current count. Closes JSONbored#7095
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7117 +/- ##
==========================================
+ Coverage 93.75% 95.98% +2.22%
==========================================
Files 692 609 -83
Lines 68809 48145 -20664
Branches 18781 15133 -3648
==========================================
- Hits 64512 46210 -18302
+ Misses 3302 1118 -2184
+ Partials 995 817 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-17 22:16:16 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
fix(scripts): scan apps/* workspaces for branding drift
BRANDING_DRIFT_PATHSPECS only covered packages/, so every apps/
workspace was invisible to the check despite the header comment's stated
"each workspace package" scope. package.json declares both apps/* and
packages/* as workspaces, and apps/loopover-ui/src already carries four
legitimate legacy-localStorage-key "gittensory" references -- a new,
unintentional reintroduction anywhere under apps/*/src would ship
silently.
Add apps//src/**/.ts, apps//src/**/.tsx (UI workspaces are TSX-heavy)
and apps//scripts/**/.mjs, mirroring the existing packages/* pathspecs.
The unscoped **/.test.ts / **/.test.tsx excludes already apply, so the
four hits are the real source files only. Regenerate the baseline to
grandfather them at their current count.
Closes #7095