fix(api): remove duplicate finding-taxonomy/enrichment-analyzers imports - #6722
Conversation
src/api/routes.ts imported buildFindingTaxonomyDocument and buildEnrichmentAnalyzersTaxonomyDocument twice (introduced by #6709), which broke `tsc --noEmit` with TS2300 duplicate-identifier errors and red-CI'd typecheck for any branch built on top of main. No behavior change -- both route handlers using these functions are unaffected.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6722 +/- ##
=======================================
Coverage ? 95.87%
=======================================
Files ? 599
Lines ? 47560
Branches ? 15072
=======================================
Hits ? 45598
Misses ? 1163
Partials ? 799
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-17 04:32:37 UTC
Review summary Nits — 3 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
src/api/routes.tsimportedbuildFindingTaxonomyDocumentandbuildEnrichmentAnalyzersTaxonomyDocumenttwice — once near the top of the import block, again a bit lower (introduced by feat(mcp): REST routes + CLI resource mirrors for finding-taxonomy and enrichment-analyzers #6709). This breakstsc --noEmitwith TS2300 duplicate-identifier errors, which red-CIs typecheck for any branch currently built on top ofmain./v1/mcp/finding-taxonomy,/v1/finding-taxonomy,/v1/mcp/enrichment-analyzers,/v1/enrichment-analyzers) are unaffected; they still resolve to the same single import.Scope
Validation
git diff --checknpm run typecheck(was failing with TS2300 before this fix, clean after)npx vitest run test/integration/api.test.ts test/unit/mcp-pr-ai-review-findings.test.ts(routes touching the affected imports, all green)Safety