Skip to content

fix: correct four stale 'improvementSignal not wired yet' comments - #6691

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:fix/improvement-signal-stale-comments
Jul 16, 2026
Merged

fix: correct four stale 'improvementSignal not wired yet' comments#6691
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:fix/improvement-signal-stale-comments

Conversation

@lourincedaging0-commits

Copy link
Copy Markdown
Contributor

Summary

improvementSignal (epic #4737, config-as-code foundation #4738) is a fully wired, live converged feature — its sub-issues #4738#4746 all shipped and closed — but four comments still describe it as inert/never-called, misleading anyone reading the code. src/queue/processors.ts is now its real caller: convergedFeatureActive(env, repoFullName, "improvementSignal") at :7821, passed as improvementSignal into AI-review options at :9361, and gating a real buildStructuralImprovementAssessment call at :10062-10068.

This corrects the four stale comments:

  • src/review/improvement-signal-wire.ts header ("nothing calls resolveConvergedFeature … outside this feature's own tests").
  • src/signals/improvement.ts header ("consumed only by its own tests until the panel-surfacing sub-issue wires a caller").
  • src/services/ai-review.ts improvementSignal field doc ("the only reachable value until a caller starts resolving the feature").
  • packages/loopover-engine/src/focus-manifest.ts comment above CONVERGED_FEATURE_KEYS ("no tier reads the resolved value yet").

Comment-only — no runtime behavior, exports, types, or signatures change; still-accurate sub-claims (e.g. improvement.ts's complexityDeltas/duplicationDeltas no-live-source note) are left untouched. Every changed line is a comment (verified), so the Codecov patch gate does not apply. Engine build + engine-parity script test pass unchanged.

Closes #6608.

improvementSignal (epic JSONbored#4737) shipped and its sub-issues (JSONbored#4738-JSONbored#4746) all
closed, but four module/doc comments still described it as inert/test-only.
src/queue/processors.ts is now its real caller (convergedFeatureActive +
buildStructuralImprovementAssessment, gated on the resolved value). Correct the
headers in improvement-signal-wire.ts and signals/improvement.ts, the
improvementSignal field doc in services/ai-review.ts, and the
CONVERGED_FEATURE_KEYS comment in engine/focus-manifest.ts to match. Comment-only;
no runtime behavior, exports, types, or signatures change (the still-accurate
sub-claims, e.g. improvement.ts's complexityDeltas note, are left as-is).

Closes JSONbored#6608.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (c4f31f0) to head (5c99190).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6691      +/-   ##
==========================================
- Coverage   93.65%   93.65%   -0.01%     
==========================================
  Files         682      682              
  Lines       68118    68112       -6     
  Branches    18711    18708       -3     
==========================================
- Hits        63795    63788       -7     
  Misses       3347     3347              
- Partials      976      977       +1     
Flag Coverage Δ
shard-1 43.95% <ø> (+0.05%) ⬆️
shard-2 36.95% <ø> (-0.02%) ⬇️
shard-3 32.47% <ø> (+0.01%) ⬆️
shard-4 34.67% <ø> (+0.43%) ⬆️
shard-5 31.68% <ø> (+0.30%) ⬆️
shard-6 45.37% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-engine/src/focus-manifest.ts 99.03% <ø> (ø)
src/review/improvement-signal-wire.ts 100.00% <ø> (ø)
src/services/ai-review.ts 96.75% <ø> (ø)
src/signals/improvement.ts 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 19:45:17 UTC

4 files · 1 AI reviewer · no blockers · readiness 77/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a pure comment-fix PR updating four stale header/doc comments that described `improvementSignal` as unwired or test-only when it is now actually consumed by `src/queue/processors.ts`. Every changed line is a comment; no exports, types, or runtime behavior change, which matches the description and the diff shown. The claim that `processors.ts` calls `convergedFeatureActive(...)` and gates `buildStructuralImprovementAssessment` is asserted but not directly visible in this diff, though it is plausible given the referenced code and closes #6608.

Nits — 4 non-blocking
  • The updated comments assert specific call-site line numbers and behavior in src/queue/processors.ts (not part of this diff) that could not be independently verified here — worth double-checking those references stay accurate as processors.ts evolves.
  • No test changes accompany this PR, which is expected for a comment-only fix but means the new comments' factual claims rely solely on manual review.
  • Consider a lightweight lint/grep check (or comment-freshness convention) to catch stale 'not wired yet' comments automatically in the future, since this is the second time such drift has needed a dedicated fix PR.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6608
Related work ⚠️ 2 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 103 registered-repo PR(s), 48 merged, 5 issue(s).
Contributor context ✅ Confirmed Gittensor contributor lourincedaging0-commits; Gittensor profile; 103 PR(s), 5 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Addressed
The diff updates all four cited comments to state that improvementSignal is now live and resolved via processors.ts, removing the 'nothing calls it' / 'only reachable until a caller resolves it' claims as requested, while leaving unrelated sub-claims (e.g. complexityDeltas note) intact.

Review context
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 3 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 2d493cd into JSONbored:main Jul 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale comments: improvementSignal is described as unwired/test-only but is actually a live caller in processors.ts

1 participant