Skip to content

fix(engine): align predicted-gate collision risk with live gate #6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 16, 2026
Merged

fix(engine): align predicted-gate collision risk with live gate #6671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/loopover-engine/src/signals/predicted-gate-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export function buildCollisionReport(
const items = [issueItem(issue), ...linkedPrs.map(prItem)];
clusters.set(`issue-${issue.number}`, {
id: `issue-${issue.number}`,
risk: linkedPrs.length > 1 || issue.linkedPrs.length > 1 ? "high" : "medium",
risk: linkedPrs.length > 1 ? "high" : "medium",
reason: `Open PR work references issue #${issue.number}.`,
items,
});
Expand Down
11 changes: 11 additions & 0 deletions test/contract/predicted-gate-engine-collision-parity.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@ describe("predicted-gate engine collision parity (#2283)", () => {
expect(collisions.clusters).toHaveLength(0);
});

it("REGRESSION (#6629): risk uses freshly-computed linkedPrs only — stale issue.linkedPrs cannot inflate to high", () => {
const directRepo = repo("owner/parity");
// Exactly one open PR actually references the issue; the issue's own linkedPrs field is stale/inflated.
const shared = issue(directRepo.fullName, 7, "Auth token refresh race", { linkedPrs: [50, 51, 52] });
const onlyLocal = pr(directRepo.fullName, 50, "Guard the token refresh race", { linkedIssues: [7] });
const collisions = buildCollisionReport(directRepo.fullName, [shared], [onlyLocal]);
const cluster = collisions.clusters.find((c) => c.id === "issue-7");
expect(cluster).toBeDefined();
expect(cluster?.risk).toBe("medium");
});

it("buildQueueHealth counts draft PRs and fires inactive_draft_prs finding when stale", () => {
const directRepo = repo("owner/draft-test");
const collisions = buildCollisionReport(directRepo.fullName, [], []);
Expand Down