feat(miner-ui): useStreamingText hook + StreamingText renderer - #6579
Closed
jaytbarimbao-collab wants to merge 1 commit into
Closed
feat(miner-ui): useStreamingText hook + StreamingText renderer#6579jaytbarimbao-collab wants to merge 1 commit into
jaytbarimbao-collab wants to merge 1 commit into
Conversation
The first streaming-text primitive for the miner-ui chat rail (JSONbored#6516): progressively reveal a chat response's text as chunks arrive, instead of popping the whole message in at once. Unwired plumbing only — no backend, no route, exercised solely against mock chunk sources in tests. - lib/use-streaming-text.ts — useStreamingText(source): consumes a ChunkSource (a () => AsyncIterable<string> factory, exported by name), accumulating each chunk into text with an idle/streaming/done/error/ cancelled status and a cancel(). Mirrors usePolledFetch's cancelled-flag discipline: a chunk resolving after a new source starts, after cancel(), or after unmount never touches state; a mid-stream throw/reject surfaces via status/error, never as an unhandled rejection. - components/streaming-text.tsx — thin <StreamingText> renderer showing the accumulated text with a caret while streaming, suppressed under prefers-reduced-motion (detected via window.matchMedia + a change listener, the use-mobile.tsx technique — no motion dependency added). Tests (co-located flat in src/, mirroring use-polled-fetch.test.ts) cover every status transition — incremental accumulation, cancel-on-new-source, cancel-on-unmount (no late write), and the error path — plus the renderer's full-motion caret vs reduced-motion suppression. Local @loopover/ui-miner gate green: typecheck + 192 tests (coverage 88/86/81/90, above the 85/85/75/85 threshold) + eslint (0 errors). Closes JSONbored#6516
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first streaming-text primitive for the miner-ui chat rail (#6516): progressively reveal a chat response's text as chunks arrive. Unwired plumbing only — no backend, no route, no live
fetch/EventSource; exercised solely against mock chunk sources in tests.Deliverables
lib/use-streaming-text.ts—useStreamingText(source)consumes aChunkSource(a() => AsyncIterable<string>factory, exported by name), accumulating each chunk intotextwith anidle | streaming | done | error | cancelledstatus and acancel(). MirrorsusePolledFetch's cancelled-flag discipline: a chunk resolving after a new source starts, aftercancel(), or after unmount never touches state; a mid-stream throw/reject surfaces viastatus/error, never as an unhandled rejection.components/streaming-text.tsx— thin<StreamingText>renderer showing the accumulated text with a caret while streaming, suppressed underprefers-reduced-motion(viawindow.matchMedia+ achangelistener — theuse-mobile.tsxtechnique; nomotiondependency).use-streaming-text.test.ts+streaming-text.test.tsx— co-located flat insrc/, mirroringuse-polled-fetch.test.ts.Tests (every branch)
Incremental accumulation; cancel-on-new-source; cancel-on-unmount (no late write); mid-stream error →
status: error; renderer full-motion caret vs reduced-motion suppression.apps/**is Codecov-ignored, so the operative gate is the local vitest coverage threshold (85/85/75/85) — this suite lands at 88/86/81/90. Local@loopover/ui-minertypecheck + 192 tests + fullnpm run ui:lint(0 errors) all green.Resubmit of #6573, which an automated pass closed on a CI-only "UI lint" step failure that does not reproduce locally (the full
npm run ui:lintexits 0 here; both UI workspaces report 0 errors) — rebased on latest main.Closes #6516