fix(engine): stop the collision report using unscoped issue.linkedPrs for risk escalation - #6470
Merged
Merged
Conversation
buildCollisionReport's issue-cluster risk escalation ORed in the raw, unverified issue.linkedPrs field (parsed from contributor-controlled issue body text mentions) alongside the genuinely-scoped linkedPrs (real open PRs whose body actually closes the issue). An issue with exactly one real competing PR but multiple unrelated "PR #N" mentions in its body text was incorrectly escalated to high risk, producing a false-positive duplicate-overlap warning annotation on the PR and inflating the reported high-risk-collision count. Risk now derives only from the scoped linkedPrs list. Add a regression test covering the exact scenario: a single real linked PR plus a multi-entry issue.linkedPrs text-mention field, asserting the cluster stays medium risk.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
loopover-orb
Bot
added
the
gittensor:bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6470 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 589 589
Lines 47025 47025
Branches 14951 14951
=======================================
Hits 44952 44952
Misses 1291 1291
Partials 782 782
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 1 confirmed adversarial-audit finding(s) in
packages/loopover-engine/src/signals/engine.ts:packages/loopover-engine/src/signals/engine.ts)Each fix follows the audit's own verified failure scenario and root-cause analysis (2-independent-skeptic adversarial verification pass, both had to vote "confirmed").
Closes #6419
Test plan
npm run test:ci) green