chore(review): converge 9 hand-duplicated src/review/ files onto their @loopover/engine shims - #6437
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
…r @loopover/engine shims All 9 files were byte-identical or import-path-only-divergent duplicates of their packages/loopover-engine/src/review/ counterparts (reconfirmed via diff before converting each one). Convert them to thin re-export shims matching src/settings/auto-close-exempt.ts's established pattern. None of the 9 engine-side files are touched. Two follow-on fixes for regression-guard tests that assert against the pre-conversion state: - check-engine-parity-script.test.ts's discovered-pair floor and guardrail-config.ts structural assertion, both now reflecting the 9 fewer duplicated pairs (change-guardrail.ts/preflight-limits.ts, tracked separately by JSONbored#6204, are the only ones left). - agent-actions.test.ts's CONCRETE_EVIDENCE_BLOCKER_CODES parity check for pre_merge_check_required now reads the real producer (the engine file) instead of the now-shimmed src/ copy. Closes JSONbored#6203
4791905 to
ef89b61
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6437 +/- ##
==========================================
- Coverage 95.61% 95.59% -0.03%
==========================================
Files 598 589 -9
Lines 47308 47026 -282
Branches 15053 14952 -101
==========================================
- Hits 45233 44953 -280
Misses 1291 1291
+ Partials 784 782 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-16 08:10:01 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #6203
Summary
src/↔@loopover/engineconvergence epic (Epic: converge remaining 15 hand-duplicated src/ <-> @loopover/engine files onto thin re-export shims #6202). All 9 named files insrc/review/were byte-identical or import-path-only-divergent duplicates of theirpackages/loopover-engine/src/review/counterparts (re-confirmed viadifffor every pair before converting, per the issue's own requirement — 8 of 9 differed only in how they imported shared types, e.g.../typesinsrc/vs../types/manifest-deps-types.js/../types/predicted-gate-types.jsin the engine tree;enrichment-analyzer-names.tswas byte-identical).export * from "../../packages/loopover-engine/src/review/<file>"), matchingsrc/settings/auto-close-exempt.ts's established pattern exactly. None of the 9 engine-side files are touched — confirmed viadiffagainstmainfor each.src/**continues to resolve the identical exported names/types/functions, just sourced through the engine module now — no call-site changes needed anywhere.Two follow-on fixes for regression-guard tests
Both tests assert against the file set's pre-conversion shape, so converting real duplicates to shims (working as intended) breaks their hardcoded expectations — fixed both to reflect the new, correct state rather than loosening or deleting the guards:
check-engine-parity-script.test.ts'sdiscoverEngineParityPairsregression-guard floor drops from 10 to 2 (onlysrc/signals/change-guardrail.tsandpreflight-limits.tsremain — tracked separately by chore(signals): converge change-guardrail.ts and preflight-limits.ts onto their @loopover/engine shims #6204), and itsguardrail-config.tsstructural assertion flips fromtruetofalse.agent-actions.test.ts'sCONCRETE_EVIDENCE_BLOCKER_CODESparity check forpre_merge_check_requirednow reads its real producer,packages/loopover-engine/src/review/pre-merge-checks.ts, instead of the now-shimmedsrc/review/pre-merge-checks.ts(the literal string no longer lives in the shim).Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typecheck(root) — reliably OOMs on this shared sandbox regardless of what changed (reproduced repeatedly this session). Rannpm run build --workspace @loopover/engine(the lighter, independent cross-package typecheck) clean, andnpm run engine-parity:drift-checkreports the 7 deliberately-hand-duplicated (twin) file pairs still agree — this convergence doesn't touch that list, it converts 9 fully-duplicated files to shims instead.npm run test:coverage— not run repo-wide (same OOM risk). Ran every real importer's test suite directly across all 9 converted files: 22 test files, 893 tests, all passing (list in commit message). Also rannpm run test:live-gate-parity(15 tests) andnpm run test:engine-parity(15 tests) — both pass, directly relevant since several of these files (cla-check.ts,guardrail-config.ts,pre-merge-checks.ts) feed the exact gate-decision logic those contract suites cross-check.npm run test:workers— N/A, no Worker-facing behavior changed (pure re-export, same runtime values).npm run build:mcp/npm run test:mcp-pack— N/A, no@loopover/mcpchanges.npm run ui:openapi:check/ui:lint/ui:typecheck/ui:build— N/A, noapps/loopover-uichanges.npm audit --audit-level=moderate— 0 vulnerabilities.If any required check was skipped, explain why:
npm run typecheck/npm run test:coverage: reliably OOMs on this shared sandbox under memory pressure from concurrent sessions, independent of the diff. Substituted with@loopover/engine's own build (clean), the engine-parity drift check (clean), and every real importer's test suite plus both gate-parity contract suites (923 tests total across this PR's verification, all passing).Safety
UI Evidencesection below with screenshots. — N/A, no visible UI change.CHANGELOG.mduntouched.Notes
change-guardrail.ts/preflight-limits.ts) — both touchcheck-engine-parity-script.test.ts's regression-guard floor but for disjoint file sets, so whichever merges second will need a routine rebase of that one test file, not a real conflict.