Skip to content

chore(review): converge 9 hand-duplicated src/review/ files onto their @loopover/engine shims - #6437

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
galuis116:chore/converge-review-engine-shims
Jul 16, 2026
Merged

chore(review): converge 9 hand-duplicated src/review/ files onto their @loopover/engine shims#6437
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
galuis116:chore/converge-review-engine-shims

Conversation

@galuis116

Copy link
Copy Markdown
Contributor

Closes #6203

Summary

  • Part of the src/@loopover/engine convergence epic (Epic: converge remaining 15 hand-duplicated src/ <-> @loopover/engine files onto thin re-export shims #6202). All 9 named files in src/review/ were byte-identical or import-path-only-divergent duplicates of their packages/loopover-engine/src/review/ counterparts (re-confirmed via diff for every pair before converting, per the issue's own requirement — 8 of 9 differed only in how they imported shared types, e.g. ../types in src/ vs ../types/manifest-deps-types.js/../types/predicted-gate-types.js in the engine tree; enrichment-analyzer-names.ts was byte-identical).
  • Converted all 9 to thin re-export shims (export * from "../../packages/loopover-engine/src/review/<file>"), matching src/settings/auto-close-exempt.ts's established pattern exactly. None of the 9 engine-side files are touched — confirmed via diff against main for each.
  • Every real (non-test) importer across src/** continues to resolve the identical exported names/types/functions, just sourced through the engine module now — no call-site changes needed anywhere.

Two follow-on fixes for regression-guard tests

Both tests assert against the file set's pre-conversion shape, so converting real duplicates to shims (working as intended) breaks their hardcoded expectations — fixed both to reflect the new, correct state rather than loosening or deleting the guards:

  • check-engine-parity-script.test.ts's discoverEngineParityPairs regression-guard floor drops from 10 to 2 (only src/signals/change-guardrail.ts and preflight-limits.ts remain — tracked separately by chore(signals): converge change-guardrail.ts and preflight-limits.ts onto their @loopover/engine shims #6204), and its guardrail-config.ts structural assertion flips from true to false.
  • agent-actions.test.ts's CONCRETE_EVIDENCE_BLOCKER_CODES parity check for pre_merge_check_required now reads its real producer, packages/loopover-engine/src/review/pre-merge-checks.ts, instead of the now-shimmed src/review/pre-merge-checks.ts (the literal string no longer lives in the shim).

Scope

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck (root) — reliably OOMs on this shared sandbox regardless of what changed (reproduced repeatedly this session). Ran npm run build --workspace @loopover/engine (the lighter, independent cross-package typecheck) clean, and npm run engine-parity:drift-check reports the 7 deliberately-hand-duplicated (twin) file pairs still agree — this convergence doesn't touch that list, it converts 9 fully-duplicated files to shims instead.
  • npm run test:coverage — not run repo-wide (same OOM risk). Ran every real importer's test suite directly across all 9 converted files: 22 test files, 893 tests, all passing (list in commit message). Also ran npm run test:live-gate-parity (15 tests) and npm run test:engine-parity (15 tests) — both pass, directly relevant since several of these files (cla-check.ts, guardrail-config.ts, pre-merge-checks.ts) feed the exact gate-decision logic those contract suites cross-check.
  • npm run test:workers — N/A, no Worker-facing behavior changed (pure re-export, same runtime values).
  • npm run build:mcp / npm run test:mcp-pack — N/A, no @loopover/mcp changes.
  • npm run ui:openapi:check / ui:lint / ui:typecheck / ui:build — N/A, no apps/loopover-ui changes.
  • npm audit --audit-level=moderate — 0 vulnerabilities.
  • New/changed behavior has tests — N/A new behavior (pure convergence to re-exports); the full existing test suite for all 9 files' consumers passes unchanged, confirming each shim is behaviorally identical to its prior full duplicate.

If any required check was skipped, explain why:

  • Root npm run typecheck / npm run test:coverage: reliably OOMs on this shared sandbox under memory pressure from concurrent sessions, independent of the diff. Substituted with @loopover/engine's own build (clean), the engine-parity drift check (clean), and every real importer's test suite plus both gate-parity contract suites (923 tests total across this PR's verification, all passing).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A.
  • API/OpenAPI/MCP behavior is updated and tested where needed. — N/A.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. — N/A, no UI changes.
  • Visible UI changes include a UI Evidence section below with screenshots. — N/A, no visible UI change.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs. — CHANGELOG.md untouched.

Notes

@galuis116
galuis116 requested a review from JSONbored as a code owner July 16, 2026 07:32
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

…r @loopover/engine shims

All 9 files were byte-identical or import-path-only-divergent
duplicates of their packages/loopover-engine/src/review/ counterparts
(reconfirmed via diff before converting each one). Convert them to
thin re-export shims matching src/settings/auto-close-exempt.ts's
established pattern. None of the 9 engine-side files are touched.

Two follow-on fixes for regression-guard tests that assert against
the pre-conversion state:
- check-engine-parity-script.test.ts's discovered-pair floor and
  guardrail-config.ts structural assertion, both now reflecting the
  9 fewer duplicated pairs (change-guardrail.ts/preflight-limits.ts,
  tracked separately by JSONbored#6204, are the only ones left).
- agent-actions.test.ts's CONCRETE_EVIDENCE_BLOCKER_CODES parity
  check for pre_merge_check_required now reads the real producer
  (the engine file) instead of the now-shimmed src/ copy.

Closes JSONbored#6203
@galuis116
galuis116 force-pushed the chore/converge-review-engine-shims branch from 4791905 to ef89b61 Compare July 16, 2026 07:45
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.59%. Comparing base (8b85ce8) to head (ef89b61).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6437      +/-   ##
==========================================
- Coverage   95.61%   95.59%   -0.03%     
==========================================
  Files         598      589       -9     
  Lines       47308    47026     -282     
  Branches    15053    14952     -101     
==========================================
- Hits        45233    44953     -280     
  Misses       1291     1291              
+ Partials      784      782       -2     
Flag Coverage Δ
shard-1 44.07% <ø> (+0.14%) ⬆️
shard-2 37.00% <ø> (+0.10%) ⬆️
shard-3 32.29% <ø> (+0.06%) ⬆️
shard-4 34.41% <ø> (+0.08%) ⬆️
shard-5 31.49% <ø> (+0.05%) ⬆️
shard-6 45.51% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 08:10:01 UTC

11 files · 1 AI reviewer · no blockers · readiness 82/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR replaces 9 hand-duplicated src/review/ implementation files with thin `export * from` re-export shims pointing at their already-verified-identical @​loopover/engine counterparts, matching the established shim pattern from src/settings/auto-close-exempt.ts. The two follow-on test fixes are correctly targeted at the real regression: the parity-discovery floor test now asserts `toBe(0)` (a precise, non-vacuous guard) instead of a loose lower bound, and the CONCRETE_EVIDENCE_BLOCKER_CODES parity check for `pre_merge_check_required` is updated to point at the new real producer file. The diff closes #6203 as described, and the shown engine-side cla-check.ts content confirms at least one of the nine engine counterparts genuinely exists with matching exports.

Nits — 3 non-blocking
  • Only 8 of 9 engine-side counterparts are shown in the provided reference context (cla-check.ts) — I could not directly verify the other 8 files' export shapes (e.g. screenshot-table-gate.ts's many named exports) exactly match what src/** callers import, though the PR description states this was confirmed via `diff` for every pair.
  • The shim comment blocks are fairly verbose and repeated near-verbatim across all 9 files (nit: could be a one-line comment given the pattern is already documented at src/settings/auto-close-exempt.ts).
  • Consider a shorter shim comment (one line pointing to auto-close-exempt.ts as the canonical pattern doc) rather than repeating the same 4-line explanation in all 9 files, to reduce diff noise on any future shim conversions.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6203
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 1934 registered-repo PR(s), 1273 merged, 54 issue(s).
Contributor context ✅ Confirmed Gittensor contributor galuis116; Gittensor profile; 1934 PR(s), 54 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The PR converts all 9 named src/review/ files into thin `export * from` shims pointing at their packages/loopover-engine/src/review/ counterparts, matching the auto-close-exempt.ts pattern and leaving engine-side files untouched, plus fixes two regression-guard tests that hardcoded the pre-conversion file count/behavior. The diff evidence (full deletions replaced by single re-export lines) directl

Review context
  • Author: galuis116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 1934 PR(s), 54 issue(s).
  • Related work: Titles/paths share 11 meaningful terms. (issue #6202, issue #6203)
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 4c902c4 into JSONbored:main Jul 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(review): converge 9 hand-duplicated src/review/ files onto their @loopover/engine shims

1 participant