Skip to content

fix(ui): mount ConfigGeneratorYamlPreview in the config generator panel - #6371

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jsdevninja:feat/fix-config-generator-yaml-preview
Jul 16, 2026
Merged

fix(ui): mount ConfigGeneratorYamlPreview in the config generator panel#6371
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jsdevninja:feat/fix-config-generator-yaml-preview

Conversation

@jsdevninja

Copy link
Copy Markdown
Contributor

Summary

Scope

  • Conventional Commit title
  • Focused UI fix under apps/loopover-ui/
  • Linked open issue

Note: this issue carries the visual label (owner-led). Expect the loopover gate to hold for owner review rather than auto-merge.

Validation

  • npm --workspace @loopover/ui run test -- src/components/site/app-panels/config-generator-panel.test.tsx — 2 passed
  • Codecov patch N/A for apps/**

Safety

  • No secrets / wallets / scoring surfaces
  • No changelog / site edits

UI Evidence

State / title JPG evidence
Empty preview (header-only YAML) Empty preview
Filled preview (combine: consensus) Filled preview
Mobile preview Mobile preview

Closes #6183

Wire the already-tested YAML preview into ConfigGeneratorPanel so live formState is visible as operators fill the form. Closes JSONbored#6183.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jsdevninja
jsdevninja requested a review from JSONbored as a code owner July 16, 2026 04:53
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 05:17:21 UTC

2 files · 1 AI reviewer · no blockers · readiness 83/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a small, correctly-targeted fix: it mounts the previously-orphaned ConfigGeneratorYamlPreview component inside ConfigGeneratorPanel, wiring it to the same formState the field groups already update, and adds a panel-level test verifying both initial render and reactivity to a field change. The diff is minimal (2 lines in the panel, one new test file), matches the PR description exactly, and CI passed. This closes #6183 as described with no scope creep.

Nits — 4 non-blocking
  • The test relies on loosely-matched text assertions (e.g. screen.getByText(/The exact/)) which are brittle to copy changes in ConfigGeneratorYamlPreview; consider a more stable selector like a data-testid or aria-label.
  • No test asserts the preview reacts to ReesAnalyzerFieldGroup changes, only AiProviderModeFieldGroup — worth at least a comment on why one field group is representative of the shared formState wiring.
  • apps/loopover-ui/.../config-generator-panel.test.tsx: add a data-testid to the Preview heading/output in ConfigGeneratorYamlPreview for more resilient assertions.
  • Consider a brief inline comment noting why only one field group's update is exercised, since both groups write to the same formState object.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6183
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 198 registered-repo PR(s), 127 merged, 42 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jsdevninja; Gittensor profile; 198 PR(s), 42 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The diff mounts ConfigGeneratorYamlPreview inside ConfigGeneratorPanel wired to the existing formState, exactly as requested, without modifying the preview component's own logic, and adds a test verifying the preview renders and updates on form changes.

Review context
  • Author: jsdevninja
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 198 PR(s), 42 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add a concise scope and risk note.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit d31cecb into JSONbored:main Jul 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ui): config generator never mounts ConfigGeneratorYamlPreview, so it never shows the user the YAML it generates

1 participant