Skip to content

fix(selfhost): route boot-time advisories through console.error so Sentry can see them #6350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 16, 2026
Merged

fix(selfhost): route boot-time advisories through console.error so Sentry can see them #6350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,14 @@ async function main(): Promise<void> {
backupAcknowledged: process.env.BACKUP_ACKNOWLEDGED === "true",
};
const backupAdvisory = sqliteBackupAdvisory(sqliteBackupOpts);
// #6325: console.error, not console.warn -- installStructuredLogForwarding (initSentry, above) only
// intercepts console.log (level:error/fatal only) and console.error (always forwarded); console.warn is
// NEVER wrapped at all, so this "warn LOUDLY" advisory was silently unreachable by Sentry regardless of
// whether Sentry was configured. `level: "warn"` in the payload still maps this to Sentry's own "warning"
// severity (see forwardStructuredLogToSentry), not an "error" -- only the CONSOLE METHOD used to reach the
// forwarder changes here, not the reported severity.
if (backupAdvisory)
console.warn(
console.error(
JSON.stringify({
level: "warn",
event: "selfhost_backup_advisory",
Expand All @@ -460,8 +466,12 @@ async function main(): Promise<void> {
acknowledged: process.env.PUBLIC_ORIGIN_ACKNOWLEDGED === "true",
};
const publicOriginAdvisory = publicOriginReachabilityAdvisory(publicOriginOpts);
// #6325: console.error, not console.warn -- see the backupAdvisory case just above for why. This is the
// advisory that motivated the fix: JSONbored/metagraphed#6036 observed a genuinely broken "after" screenshot
// in production, and this advisory existed specifically to catch that -- but had been silently unreachable
// by Sentry the whole time, so nobody was ever actually alerted.
if (publicOriginAdvisory)
console.warn(
console.error(
JSON.stringify({
level: "warn",
event: "selfhost_public_origin_advisory",
Expand Down
Loading