Skip to content

docs(ams): port docs/unattended-scheduling.md to a website docs page (docs.ams-unattended-scheduling.tsx) - #6338

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
oktofeesh1:docs/ams-unattended-scheduling-6025
Jul 16, 2026
Merged

docs(ams): port docs/unattended-scheduling.md to a website docs page (docs.ams-unattended-scheduling.tsx)#6338
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
oktofeesh1:docs/ams-unattended-scheduling-6025

Conversation

@oktofeesh1

Copy link
Copy Markdown
Contributor

Summary

Scope

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally — UI-only page addition under apps/loopover-ui/** (outside coverage.include); codecov/patch does not apply
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • Full npm run test:ci run locally from a clean npm ci install, green: 896 test files / 17,180 tests passed

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A, no such changes in this PR
  • API/OpenAPI/MCP behavior is updated and tested where needed. — N/A, no API/OpenAPI/MCP behavior changed
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. — N/A, static docs content only
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

…(docs.ams-unattended-scheduling.tsx)

Add content/docs/ams-unattended-scheduling.mdx covering the manage-poll/
discover exit-code alerting contract, cron and systemd wiring with the
common failure-masking pitfalls, and a scheduler-agnostic wrapper-script
pattern -- rendered via the existing DocsPage/Callout/CodeBlock/FeatureRow
primitives. Add the page to docs-nav.tsx's "AMS: deployment" subgroup and to
docs.index.tsx's Maintainers audience card.

packages/loopover-miner/docs/unattended-scheduling.md stays as the canonical
source (ships inside the published @loopover/miner package) with a short
pointer added to the new website page.
@oktofeesh1
oktofeesh1 requested a review from JSONbored as a code owner July 16, 2026 02:42
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 02:51:35 UTC

6 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR ports packages/loopover-miner/docs/unattended-scheduling.md to a new website docs page at content/docs/ams-unattended-scheduling.mdx, following the established DocsPage/Callout/CodeBlock/FeatureRow pattern from prior migrations (#6022/#6023/#6024), with matching route, nav, and index wiring plus a codegen'd routeTree.gen.ts. The content itself accurately preserves the exit-code contract, the MAILTO and bare `|| logger` pitfalls, and the cron/systemd/wrapper-script patterns from the canonical source, and the canonical markdown file gets a pointer back to the new page rather than being deleted. This is a mechanical, well-targeted docs port with no functional code changes.

Nits — 5 non-blocking
  • The generated routeTree.gen.ts is included in the diff, which is expected for this router but is worth double-checking it was produced by the actual codegen command rather than hand-edited.
  • apps/loopover-ui/content/docs/ams-unattended-scheduling.mdx:69 duplicates the systemd OnFailure alert-unit snippet already fully shown later in the 'Alerting on failure' section — minor redundancy but harmless for a docs page.
  • Consider a lightweight visual/regression check that the new /docs/ams-unattended-scheduling route renders (screenshot or manual click-through) since this is UI-only and outside coverage.include per the PR description.
  • Verify the MDX CodeBlock `lang="cron"` and `lang="ini"` values match the syntax highlighter's supported language list used elsewhere in the docs (e.g., ams-deployment.mdx) for consistent highlighting.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6025
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 58 registered-repo PR(s), 47 merged, 1 issue(s).
Contributor context ✅ Confirmed Gittensor contributor oktofeesh1; Gittensor profile; 58 PR(s), 1 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Partially addressed
The PR does create the required apps/loopover-ui/src/routes/docs.ams-unattended-scheduling.tsx with the real content and nav wiring in docs-nav.tsx and docs.index.tsx, satisfying the core deliverable, but it leaves docs/unattended-scheduling.md's substantive content fully intact (only adding a pointer at the top) rather than deleting it or reducing it to a one-line stub as the issue explicitly req

Review context
  • Author: oktofeesh1
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 58 PR(s), 1 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (issue #6031)
  • Related work: Titles/paths share 6 meaningful terms. (issue #6027)
  • Related work: Titles/paths share 6 meaningful terms. (issue #6030)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 39efc75 into JSONbored:main Jul 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(ams): port docs/unattended-scheduling.md to a website docs page (docs.ams-unattended-scheduling.tsx)

1 participant