fix(ui): generate fumadocs-mdx collections/* via postinstall - #6310
Merged
JSONbored merged 1 commit intoJul 16, 2026
Merged
Conversation
…ed#6304) apps/loopover-ui/tsconfig.json maps collections/* to ./.source/*, which fumadocs-mdx's Vite plugin generates from source.config.ts. .source/ is gitignored and nothing generated it outside of an actual vite dev/build run, so tsc --noEmit (ui:typecheck, unlike ui:build, never invokes Vite first) fails to resolve collections/browser and collections/server on a fresh checkout -- broken since the fumadocs-mdx docs migration landed and only masked locally by leftover .source/ files from a prior dev/build run. Wire fumadocs-mdx's own generator (its bin, designed for exactly this) as a postinstall script so npm ci always regenerates .source/ before any other script runs.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
JSONbored
approved these changes
Jul 16, 2026
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/loopover-ui/tsconfig.jsonmapscollections/*to./.source/*, a directory fumadocs-mdx's Vite plugin generates fromsource.config.ts..source/is gitignored and nothing generated it outside of an actualvite dev/vite buildrun.npm run ui:typecheck(and therefore CI'svalidate-code/validatejobs) runs baretsc --noEmitwith no prior Vite invocation, so on a genuinely fresh checkoutcollections/browser/collections/serverfail to resolve (TS2307: Cannot find module).apps/loopover-uisince inherits the same failure on a fresh CI runner, even whennpm run test:cipasses locally on a working tree that has ever runvite dev/buildbefore (which leaves.source/on disk).node_modules/.bin/fumadocs-mdx, its documented postinstall entry point) asapps/loopover-ui/package.json'spostinstallscript, sonpm cialways regenerates.source/before any other script runs.Scope
type(scope): short summaryConventional Commit format.package.jsonscript, the correspondingpackage-lock.jsonmetadata bit) isolated from any content/feature work.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally —apps/loopover-ui/**only, outsidecoverage.include;codecov/patchdoes not applynpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderaterm -rf apps/loopover-ui/.source && npm ci --prefer-offline --no-audit --no-fund(the literal command CI runs) regenerates.source/via the newpostinstallhook, andnpm --workspace apps/loopover-ui run typecheckthen passes — it failed with the identicalTS2307errors before this fix.Safety
Notes
apps/loopover-ui, including the AMS docs-porting sub-issue PRs currently being worked (docs(ams): port DEPLOYMENT.md to a website docs page (docs.ams-deployment.tsx) #6022, docs(ams): port docs/operations-runbook.md to a website docs page (docs.ams-operations-runbook.tsx) #6023, ...).