review: drop redundant banner + demote readiness chip off-ready - #6077
Conversation
The 12x repeated-square banner row duplicated the color the alert blockquote already renders; the readiness score (advisory-only, never feeds the gate) read as contradictory next to a non-"ready" verdict. Also gives the Suggested Action line its own nested-blockquote box so it's visually distinct from the surrounding body text. Closes #6066
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6077 +/- ##
===========================================
+ Coverage 74.96% 95.23% +20.26%
===========================================
Files 594 595 +1
Lines 46972 47012 +40
Branches 15015 15015
===========================================
+ Hits 35214 44770 +9556
+ Misses 8691 1493 -7198
+ Partials 3067 749 -2318
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-15 08:40:37 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #6066.
Summary
meta.square.repeat(12)banner row — the alert blockquote (> [!CAUTION]/[!TIP]/etc.) already renders the same color + icon; the repeated-emoji row was pure decoration on top of that.readiness N/100chip when the derived status is"ready". The score is advisory-only and never feeds the gate (seederiveUnifiedStatus's own comments) — showing it next to a blocked/held/advisory verdict reads as contradictory.nestedBox) instead of a plain bold paragraph in the body flow. Pure markdown (two-deep blockquote nesting), no custom HTML.First of a small sequence of PRs from #6065 (comment redesign + config cleanup epic).
Test plan
npx vitest run test/unit/unified-comment.test.ts— 91/91 pass, including 3 new/updated tests locking in the banner removal, the readiness-chip gating, and the nested verdict box.npx tsc --noEmitclean (afternpm run build --workspace @loopover/engine)npm run docs:drift-check,npm run manifest:drift-check,npm run command-reference:check— all pass (unaffected, run as a sanity check)coverage-final.json— no uncovered statements/branches within the changed lines