Skip to content

review: drop redundant banner + demote readiness chip off-ready - #6077

Merged
loopover-orb[bot] merged 1 commit into
mainfrom
review/comment-verdict-visual-cleanup
Jul 15, 2026
Merged

review: drop redundant banner + demote readiness chip off-ready#6077
loopover-orb[bot] merged 1 commit into
mainfrom
review/comment-verdict-visual-cleanup

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Closes #6066.

Summary

  • Drop the meta.square.repeat(12) banner row — the alert blockquote (> [!CAUTION]/[!TIP]/etc.) already renders the same color + icon; the repeated-emoji row was pure decoration on top of that.
  • Only render the readiness N/100 chip when the derived status is "ready". The score is advisory-only and never feeds the gate (see deriveUnifiedStatus's own comments) — showing it next to a blocked/held/advisory verdict reads as contradictory.
  • Give the "Suggested Action" verdict line — the single most load-bearing line in the comment — its own nested-blockquote sub-block (nestedBox) instead of a plain bold paragraph in the body flow. Pure markdown (two-deep blockquote nesting), no custom HTML.

First of a small sequence of PRs from #6065 (comment redesign + config cleanup epic).

Test plan

  • npx vitest run test/unit/unified-comment.test.ts — 91/91 pass, including 3 new/updated tests locking in the banner removal, the readiness-chip gating, and the nested verdict box.
  • npx tsc --noEmit clean (after npm run build --workspace @loopover/engine)
  • npm run docs:drift-check, npm run manifest:drift-check, npm run command-reference:check — all pass (unaffected, run as a sanity check)
  • Coverage-checked the exact diff hunks against coverage-final.json — no uncovered statements/branches within the changed lines

The 12x repeated-square banner row duplicated the color the alert
blockquote already renders; the readiness score (advisory-only, never
feeds the gate) read as contradictory next to a non-"ready" verdict.
Also gives the Suggested Action line its own nested-blockquote box so
it's visually distinct from the surrounding body text.

Closes #6066
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.23%. Comparing base (a8acb4c) to head (6d442d5).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6077       +/-   ##
===========================================
+ Coverage   74.96%   95.23%   +20.26%     
===========================================
  Files         594      595        +1     
  Lines       46972    47012       +40     
  Branches    15015    15015               
===========================================
+ Hits        35214    44770     +9556     
+ Misses       8691     1493     -7198     
+ Partials     3067      749     -2318     
Flag Coverage Δ
shard-1 43.94% <70.00%> (-0.07%) ⬇️
shard-2 36.57% <40.00%> (+0.12%) ⬆️
shard-3 31.94% <40.00%> (?)
shard-4 33.77% <100.00%> (?)
shard-5 31.46% <30.00%> (?)
shard-6 44.67% <30.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/review/unified-comment.ts 99.59% <100.00%> (+26.97%) ⬆️

... and 283 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-15 08:40:37 UTC

2 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This diff removes the redundant 12x-emoji banner row, gates the readiness chip to only show when status is "ready" (since the score is advisory and never feeds the gate), and nests the verdict line in a two-deep blockquote sub-block via a new `nestedBox` helper. The changes are narrow, well-documented with rationale comments, and each behavior change is locked in by new/updated tests including negative assertions for the removed banner and hidden chip. The `nestedBox` implementation is straightforward (splits on newline, prefixes each line with `> `) and composes correctly with the existing `asAlert` re-prefixing described in the comment.

Nits — 5 non-blocking
  • src/review/unified-comment.ts: the doc comment on `nestedBox` is quite long (6 lines) for a 5-line function — could be trimmed to the non-obvious part (that every input line is guaranteed non-empty, so no blank-line special case is needed).
  • test/unit/unified-comment.test.ts: the banner-detection regex `/(🟩|🟦|🟨|🟥){12}/` is a reasonable proxy but is coupled to the exact repeat count (12) from the old implementation; a comment noting this is intentional (already present) is good but the test would silently stop catching a re-introduced banner if someone changed the repeat count.
  • Consider verifying `nestedBox` behavior with a multi-line input (verdict + reason bullets) in the tests, since the current assertions only check the single-line merge case.
  • The PR description mentions this is the first of a sequence tied to Epic: ORB review-comment redesign + config-as-code cleanup #6065 — worth confirming the linked issue review: drop redundant square banner + demote readiness chip on non-ready verdicts #6066 is fully closed by this PR alone rather than partially addressed.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #6066
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 43 registered-repo PR(s), 35 merged, 360 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 43 PR(s), 360 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff removes the `meta.square.repeat(12)` banner, gates the readiness chip behind `status === "ready"`, and gives the Suggested Action verdict line its own nested-blockquote treatment via `nestedBox()`, matching all three asks in the issue, with corresponding tests updated.

Review context
Contributor next steps
  • Start here: Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Then work through the remaining 3 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 889123b into main Jul 15, 2026
17 checks passed
@loopover-orb
loopover-orb Bot deleted the review/comment-verdict-visual-cleanup branch July 15, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review: drop redundant square banner + demote readiness chip on non-ready verdicts

1 participant