Skip to content

fix(analytics): don't credit a pre-action merged PR as accepted #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 3 commits into from
Jun 12, 2026
Merged

fix(analytics): don't credit a pre-action merged PR as accepted #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44cffe4
fix(analytics): don't credit a pre-action merged PR as accepted
philluiz2323 Jun 11, 2026
99e5a41
Merge branch 'main' into fix/recommendation-outcome-preaction-merge
JSONbored Jun 12, 2026
992de93
Merge branch 'main' into fix/recommendation-outcome-preaction-merge
JSONbored Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/services/recommendation-outcomes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,11 @@ function pullRequestOutcomeState(
if (hasChangesRequestedReview(pr)) return "rejected";
if (hasPositiveOpenPullRequestSignal(pr)) return "improved";
}
if (createdAt >= actionAt || updatedAt > actionAt) return "accepted";
// A PR that already merged before the action cannot be a positive outcome of it. Without this guard a
// pre-action merge that merely receives a later updatedAt bump (e.g. a comment) would fall through to
// "accepted" -- mirror the "merged" branch's own >= actionAt discipline so it stays stale/ignored.
const mergedBeforeAction = Number.isFinite(mergedAt) && mergedAt < actionAt;
if (!mergedBeforeAction && (createdAt >= actionAt || updatedAt > actionAt)) return "accepted";
if (actionAgeMs >= staleAfterMs) return "stale";
return "ignored";
}
Expand Down
18 changes: 18 additions & 0 deletions test/unit/recommendation-outcomes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,24 @@ describe("recommendation outcome feedback", () => {
}),
).toMatchObject({ outcomeState: "stale", outcomeTargetType: "pull_request" });

// A pre-action merge that merely receives a later updatedAt bump (e.g. a comment) must not be
// credited as the positive "accepted" outcome of the recommendation.
expect(
classifyRecommendationOutcome({
...base,
action: action(run, 2, { targetRepoFullName: "owner/old-merged", targetPullNumber: 62 }),
pullRequests: [
prRecord(62, "owner/old-merged", {
state: "merged",
mergedAt: "2026-04-01T00:00:00.000Z",
createdAt: "2026-03-01T00:00:00.000Z",
updatedAt: "2026-05-10T00:00:00.000Z",
}),
],
issues: [],
}),
).toMatchObject({ outcomeState: "stale", outcomeTargetType: "pull_request" });

expect(
classifyRecommendationOutcome({
...base,
Expand Down