Skip to content

fix(docs): sweep remaining gittensory-* rename residue in self-host ops docs - #6044

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
nghetienhiep:fix/issue-5937
Jul 15, 2026
Merged

fix(docs): sweep remaining gittensory-* rename residue in self-host ops docs#6044
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
nghetienhiep:fix/issue-5937

Conversation

@nghetienhiep

Copy link
Copy Markdown
Contributor

Summary

  • apps/loopover-ui/src/routes/docs.self-hosting-operations.tsx line 411 named a dead loopover-docker-safe-prune systemd timer in the disk-cleanup prose, self-contradicting the same file's own install snippet a few lines later, which installs the real loopover-docker-prune timer (also shipped at systemd/loopover-docker-prune.timer.example). Fixed the prose to name the real timer.
  • packages/loopover-miner/terraform/main.tf line 7's header comment told operators to drop secrets into a pre-rename .gittensory-miner.env; the module's own README.md and DEPLOYMENT.md already use .loopover-miner.env.example. Fixed the comment to match.
  • src/review/repo-agnostic-capability-audit.md line 8 linked to packages/gittensory-miner/docs/repo-agnostic-capability-audit.md, a dead 404 — the directory was renamed to packages/loopover-miner/. Fixed the link to the real path.
  • Added test/unit/self-host-ops-rename-residue.test.ts, a grep-based regression test (following the miner-docker-compose.test.ts pattern) asserting the three stale strings are gone and the correct replacements are present in all three files.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally — none of the three changed files are in src/**'s Codecov coverage.include (a UI route, a terraform comment, and a markdown doc), so codecov/patch doesn't gate this change directly; the new regression test in test/unit/ passes and exercises all three fixes.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • test:workers, build:mcp/test:mcp-pack, and ui:build weren't re-run standalone for this change since it touches no worker, MCP, or UI-build-affecting code (only doc prose, a terraform comment, and a markdown link) — the full npm run test:ci gate run locally covers all of these and was green apart from pre-existing, unrelated local-environment gaps (missing sqlite3 CLI binary used by an unrelated reporting-DB test, and a stray GITHUB_TOKEN env var tripping an unrelated miner test's "no token" branch) that reproduce identically on main without this diff.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — this is a text-only fix to prose/comments (a stale identifier in a code sample, a terraform header comment, and a markdown link target). No layout, styling, or rendered visual difference results; the rendered doc page's structure is unchanged.

Notes

@nghetienhiep
nghetienhiep requested a review from JSONbored as a code owner July 15, 2026 07:27
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (9597167) to head (41194c2).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6044      +/-   ##
==========================================
+ Coverage   95.17%   95.22%   +0.05%     
==========================================
  Files         592      593       +1     
  Lines       46960    46972      +12     
  Branches    15007    15015       +8     
==========================================
+ Hits        44693    44730      +37     
+ Misses       1511     1493      -18     
+ Partials      756      749       -7     
Flag Coverage Δ
shard-1 43.97% <ø> (-0.05%) ⬇️
shard-2 36.53% <ø> (+0.10%) ⬆️
shard-3 31.92% <ø> (-0.29%) ⬇️
shard-4 31.96% <ø> (-1.02%) ⬇️
shard-5 32.67% <ø> (+1.19%) ⬆️
shard-6 44.70% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

…ps docs

Fixes three isolated rename-residue spots: the self-hosting-operations doc
named a dead loopover-docker-safe-prune timer instead of the real
loopover-docker-prune one installed a few lines later in the same file, the
miner terraform module's header comment still told operators to use the
pre-rename .gittensory-miner.env filename, and the repo-agnostic capability
audit doc linked to the pre-rename packages/gittensory-miner/ path (a dead
404 link). Adds a regression test asserting the stale strings are gone and
the correct replacements are present.

Closes JSONbored#5937
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-15 07:54:48 UTC

4 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a narrowly scoped documentation/comment fix that corrects three stale `gittensory-*` naming residue instances (a systemd timer name in prose, a terraform header comment's env filename, and a cross-repo doc link) to match their already-renamed real counterparts, backed by a grep-based regression test mirroring an existing pattern. The changes are internally consistent with what the PR claims to fix and each replacement is verifiable against context cited in the description (the real timer name in the install snippet, README/DEPLOYMENT.md's actual env filename, and the renamed packages/loopover-miner directory).

Nits — 3 non-blocking
  • packages/loopover-miner/terraform/main.tf:8 now tells operators to drop secrets directly into `.loopover-miner.env.example`, an `.example`-suffixed filename that reads oddly as a literal target for real secrets — worth double-checking this exactly matches the filename used in README.md/DEPLOYMENT.md rather than being a partial fix (e.g. should the extension have been dropped for the real file operators create from the example).
  • The new test in test/unit/self-host-ops-rename-residue.test.ts only asserts substring absence/presence via `toContain`/`not.toContain`, so it would not catch a partial regression like the string reappearing in a different casing or with a trailing slash variant — acceptable for this narrow use but worth noting as a low-rigor grep test, consistent with the cited miner-docker-compose.test.ts pattern.
  • Confirm packages/loopover-miner/README.md and DEPLOYMENT.md literally use `.loopover-miner.env.example` (not `.loopover-miner.env`) as the operator-facing instruction, since that's an unusual thing to tell someone to put live secrets into.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5937
Related work ⚠️ 2 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 56 registered-repo PR(s), 28 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor nghetienhiep; Gittensor profile; 56 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
All three deliverables are fixed exactly as specified: the timer name, the terraform env comment, and the dead capability-audit link, plus a grep-based regression test asserting the stale strings are gone and correct replacements present.

Review context
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit fcedc47 into JSONbored:main Jul 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(docs): sweep remaining gittensory-* rename residue in self-host ops docs (dead timer name, dead link, stale env filename)

1 participant