Skip to content

fix(review): add missing duplicationDelta to REES_ANALYZER_NAMES - #6009

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:fix-rees-dupdelta-v3
Jul 15, 2026
Merged

fix(review): add missing duplicationDelta to REES_ANALYZER_NAMES#6009
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:fix-rees-dupdelta-v3

Conversation

@lourincedaging0-commits

Copy link
Copy Markdown
Contributor

Summary

duplicationDelta is a defined REES enrichment analyzer (present in review-enrichment/analyzer-metadata.json right beside duplication), but it was missing from the canonical REES_ANALYZER_NAMES registry in enrichment-analyzer-names.ts. That list is the single source of truth every operator REES_ANALYZERS env entry and per-repo .loopover.yml review.enrichment toggle is validated against — so an analyzer absent from it is silently un-selectable and un-toggleable. duplication was listed; its delta counterpart was the one-entry gap.

Fix

Add "duplicationDelta" to the list, right after "duplication". Applied to both twin copies the engine-parity contract keeps byte-identical:

  • src/review/enrichment-analyzer-names.ts
  • packages/loopover-engine/src/review/enrichment-analyzer-names.ts

Tests

test/unit/enrichment-analyzers-taxonomy.test.ts:

  • Set-equality against analyzer-metadata.json (the registry source of truth) — no missing, no extra — so any future analyzer added to the metadata but not the name list fails immediately, rather than a brittle hardcoded count.
  • A direct regression asserting duplicationDelta sits alongside duplication.
  • A no-duplicate-entries guard.
  • A twin-parity assertion comparing the engine copy's exported list to the server copy by value, catching a name added to one copy but not the other.

100% line coverage on both twin modules locally.

Closes #5839

REES_ANALYZER_NAMES in enrichment-analyzer-names.ts is the canonical list that
validates operator `REES_ANALYZERS` env entries and per-repo `.loopover.yml`
`review.enrichment` toggles. It listed 56 analyzers but the generated
analyzer-metadata.json registry defines 57 — `duplicationDelta` (right next to
`duplication`) was the one gap. As a result resolveReesAnalyzers rejected
`duplicationDelta` as "invalid" for operators who listed it explicitly, and
resolveEnrichmentAnalyzerSelection could never honor a per-repo toggle for it.

Add the missing entry so the list exactly matches the metadata registry, and
add a parity test asserting REES_ANALYZER_NAMES and the registry stay in sync
(set equality against the registry as source of truth, so a future analyzer
can't silently drift the two apart), plus a regression assertion for
duplicationDelta and a no-duplicates check.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (a211791) to head (05f4f27).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6009   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         591      591           
  Lines       46934    46934           
  Branches    15000    15000           
=======================================
  Hits        44664    44664           
  Misses       1512     1512           
  Partials      758      758           
Flag Coverage Δ
shard-1 43.93% <ø> (ø)
shard-2 36.54% <ø> (+0.01%) ⬆️
shard-3 32.16% <ø> (+0.16%) ⬆️
shard-4 32.93% <ø> (+0.98%) ⬆️
shard-5 31.34% <ø> (-1.20%) ⬇️
shard-6 44.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ver-engine/src/review/enrichment-analyzer-names.ts 100.00% <ø> (ø)
src/review/enrichment-analyzer-names.ts 100.00% <ø> (ø)

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-15 06:57:21 UTC

3 files · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
One-entry fix adding the missing "duplicationDelta" analyzer name to both twin copies of REES_ANALYZER_NAMES so it becomes selectable/toggleable, matching analyzer-metadata.json's existing entry. The change is minimal, correctly applied identically to both the server and engine copies (preserving the engine-parity contract), and is backed by a set-equality test against the metadata source of truth plus a twin-parity test, which is a solid regression guard for this exact class of drift.

Nits — 2 non-blocking
  • The inline comments in the test file (enrichment-analyzers-taxonomy.test.ts) are fairly verbose for what the test names already convey.
  • Consider whether the set-equality test could also assert ordering parity against metadata.json's own order, if that ordering is meant to be meaningful elsewhere (e.g. UI display order).
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5839
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 65 registered-repo PR(s), 26 merged, 4 issue(s).
Contributor context ✅ Confirmed Gittensor contributor lourincedaging0-commits; Gittensor profile; 65 PR(s), 4 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The PR adds "duplicationDelta" to REES_ANALYZER_NAMES in the exact array location the issue specified, and extends the taxonomy test suite with a set-equality drift-guard against analyzer-metadata.json plus a direct duplicationDelta regression check, fulfilling the core requirement and the drift-guard deliverable.

Review context
  • Author: lourincedaging0-commits
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 65 PR(s), 4 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit f4e327a into JSONbored:main Jul 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(review): REES_ANALYZER_NAMES is missing duplicationDelta, blocking its env/config toggles

1 participant