fix(ci): isolate GitHub write token to release job - #60
Merged
Conversation
james3773
pushed a commit
to james3773/gittensory
that referenced
this pull request
May 31, 2026
This was referenced Jul 2, 2026
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
contents: writeleft a write-scopedgithub.tokenavailable during dependency/tooling steps in.github/workflows/npm-publish.yml.actions/checkoutbehavior from persisting potentially dangerous write credentials into local git config before untrusted package/tooling execution.Description
.github/workflows/npm-publish.ymlfromcontents: writetocontents: read.publishjob withpermissions: contents: readandid-token: writeso tooling steps run with read-only repo access.persist-credentials: falseto theactions/checkoutstep to avoid writing the token into git config beforenpm ci/tests/build steps.github-releasejob that runsneeds: publishand is the only job grantedcontents: writeand which usesGH_TOKEN: ${{ github.token }}.Testing
git diff --checkwhich produced no whitespace or diff-check failures and succeeded.ruby -e 'require "yaml"; YAML.load_file(".github/workflows/npm-publish.yml")'which succeeded.npm run actionlintbut it was blocked by network/DNS resolution in the environment (github-actionlint: getaddrinfo EAI_AGAIN github.com).Codex Task