fix(review): treat a blank consentPhrase as unset in evaluateClaCheck (#5838)

[shin-core]

Summary

Closes #5838.

evaluateClaCheck (src/review/cla-check.ts) computed
phraseSatisfied = config.consentPhrase !== null && (ctx.body ?? "").toLowerCase().includes(config.consentPhrase.toLowerCase()).
When consentPhrase is the empty string "" (distinct from null/unset), "" !== null is true and
body.includes("") is unconditionally true, so phrase-match detection silently satisfied CLA consent for
every PR — a real gate bypass.

This is reachable in practice: claConsentPhrase is a dashboard/API-settable field defined in
src/openapi/schemas.ts as z.string().nullable().optional() with no non-empty validation, and it flows into
evaluateClaCheck's config unmodified — src/queue/processors.ts passes consentPhrase: settings.claConsentPhrase ?? null,
where ?? null only substitutes for undefined/null, not "". A maintainer who saves a blank value on this field
(without also turning claMode off) silently disables the entire CLA gate, with no warning anywhere.

The fix normalizes a blank/whitespace-only consentPhrase to null once at the top of evaluateClaCheck and threads
the normalized value through every use site, mirroring the config-as-code path's normalizeOptionalString
(packages/loopover-engine/src/focus-manifest.ts), which already treats an empty/whitespace-only string as null. A
blank phrase now behaves identically to leaving the field unset: the check-run method (if configured) decides,
otherwise no finding is produced — closing the gap that existed only on the DB-backed, dashboard-settable path.

The fix is applied identically to both hand-duplicated twins (src/review/cla-check.ts and
packages/loopover-engine/src/review/cla-check.ts) so the engine-parity check stays green.

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Ran the full npm run test:ci gate (exit 0) plus npm audit --audit-level=moderate (0 vulnerabilities). Both twin copies of cla-check.ts measured at 100% patch coverage (lines and branches) on the changed lines via the unsharded npm run test:coverage.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes on the Safety boxes: this is a deterministic, side-effect-free evaluator change with no UI, API/OpenAPI, or auth/CORS/session surface — the negative-path testing that applies here is the CLA-consent gate's own negative paths, which are covered: the new tests assert that a blank/whitespace-only consentPhrase does not auto-satisfy consent and instead defers to the check-run method (hold) or produces cla_consent_missing, exactly as an unset phrase would. No public-facing text or forbidden terms are added.

UI Evidence

Not applicable — backend-only change to a deterministic evaluator; no visible UI, frontend, docs, or extension surface.

Notes

• New/updated tests: test/unit/cla-check.test.ts gains a blank consentPhrase normalizes to unset (regression for #5838) block covering the empty-string and whitespace-only cases in both the phrase-only and phrase+check-run configurations, asserting the blank phrase never appears in the cla_consent_missing detail text. test/unit/predicted-gate-engine-branch-coverage.test.ts gains the equivalent cases against the @loopover/engine twin so both Codecov-measured copies hit 100% branch coverage on the changed lines.
• The existing non-empty consentPhrase behavior (the documented "either method holds" contract, the unresolved-check-run hold, and the cla_consent_missing/cla_check_unresolved codes) is unchanged.

[superagent-security]

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ LoopOver review result - manual review recommended

_{Review updated: 2026-07-15 04:59:22 UTC}

4 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · unstable

⏸️ Suggested Action - Manual Review

Review summary
This fixes a genuine gate-bypass bug: `evaluateClaCheck` normalizes a blank/whitespace-only `consentPhrase` to `null` before use, so `body.includes("")` can no longer unconditionally satisfy CLA consent for every PR. The normalized value is correctly threaded through all subsequent uses (the early-return guard, `phraseSatisfied`, and the `missing` message), and the fix is applied identically to both hand-duplicated twin files to preserve engine parity. Tests cover the empty-string and whitespace-only cases, both as the sole method and combined with a check-run, including the unresolved-hold and missing-message-omits-blank-phrase paths.

Nits — 4 non-blocking

• The normalization logic (`consentPhrase.trim().length > 0 ? consentPhrase : null`) is duplicated verbatim across the two twin files and could be pulled into a shared `normalizeOptionalString`-style helper the PR description itself cites, though the existing engine-parity convention treats this hand-duplication as expected.
• The `missing.push` message on the `consentPhrase !== null` branch (src/review/cla-check.ts and twin) doesn't trim the phrase before interpolating, so a phrase like `" agree "` with internal-only whitespace would still show untrimmed in the finding text — minor cosmetic inconsistency with the trimmed check used to decide unset-ness.
• Consider extracting the blank-to-null normalization into a small shared utility (e.g. reuse or mirror `normalizeOptionalString` from packages/loopover-engine/src/focus-manifest.ts directly) to reduce the risk of the two hand-duplicated twins drifting on this specific check in the future.
• Consider adding a validation guard in src/openapi/schemas.ts on `claConsentPhrase` (reject/trim empty strings server-side) as a defense-in-depth complement to this consumer-side fix, since the description notes the field currently has no non-empty validation.

Flagged checks (non-blocking)

• Contributor trust — Contributor flagged for review

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#5838
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 51 registered-repo PR(s), 23 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	shin-core; Gittensor profile; 51 PR(s), 0 issue(s).
Gate result	✅ Passing	No configured blocker found.
Improvement	✅ Minor	risk: clean · value: minor

Review context

• Author: shin-core
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 51 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (2f0e6d2) to head (0a10fcb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5968   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         589      589           
  Lines       46740    46742    +2     
  Branches    14922    14924    +2     
=======================================
+ Hits        44478    44480    +2     
  Misses       1511     1511           
  Partials      751      751           

Flag	Coverage Δ
shard-1	43.91% <37.50%> (+<0.01%)	⬆️
shard-2	36.05% <0.00%> (-0.01%)	⬇️
shard-3	32.04% <100.00%> (+<0.01%)	⬆️
shard-4	32.82% <0.00%> (-0.01%)	⬇️
shard-5	31.47% <37.50%> (+<0.01%)	⬆️
shard-6	44.58% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/loopover-engine/src/review/cla-check.ts	100.00% <100.00%> (ø)
src/review/cla-check.ts	100.00% <100.00%> (ø)

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.