Skip to content

fix(rebrand): rename gittensory-app.env default output path - #5959

Merged
JSONbored merged 1 commit into
mainfrom
fix/gittensory-app-env-default-path
Jul 15, 2026
Merged

fix(rebrand): rename gittensory-app.env default output path#5959
JSONbored merged 1 commit into
mainfrom
fix/gittensory-app-env-default-path

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • src/server.ts's GitHub App manifest-creation callback fell back to /data/gittensory-app.env when SETUP_OUTPUT_PATH isn't set. Renamed to /data/loopover-app.env to complete the self-host setup-wizard full-cutover rename.
  • src/server.ts is Codecov-exempt (codecov.yml); no test exercises this exact literal-path fallback directly.

Test plan

  • Full npm run test:ci gate green locally

The GitHub App manifest-creation callback's default SETUP_OUTPUT_PATH
fallback still wrote to /data/gittensory-app.env. Completes the
full-cutover self-host setup-wizard rename.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@217e96c). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5959   +/-   ##
=======================================
  Coverage        ?   95.15%           
=======================================
  Files           ?      589           
  Lines           ?    46675           
  Branches        ?    14899           
=======================================
  Hits            ?    44414           
  Misses          ?     1511           
  Partials        ?      750           
Flag Coverage Δ
shard-1 43.39% <ø> (?)
shard-2 36.30% <ø> (?)
shard-3 31.85% <ø> (?)
shard-4 31.82% <ø> (?)
shard-5 32.40% <ø> (?)
shard-6 44.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-15 01:38:32 UTC

1 file · 1 AI reviewer · 2 blockers · readiness 70/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a trivial one-line string literal rename of a default fallback path from /data/gittensory-app.env to /data/loopover-app.env, consistent with the stated rebrand cutover. The change is mechanical and correct in isolation, though the PR itself notes the file is Codecov-exempt and no test exercises this fallback literal.

Nits — 5 non-blocking
  • No issue link is provided in the description tying this to a maintainer-authorized rebrand ticket, which this repo's contribution conventions require for external PRs.
  • src/server.ts:931 — since this path is Codecov-exempt and untested, consider a quick manual/CI smoke check that the manifest-callback still writes correctly to the new default path.
  • Grep the repo for any remaining `gittensory-app.env` references (docs, docker-compose, README setup instructions) to ensure this isn't the only place the old name survives.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue — Link the relevant issue (for example Closes #123) before opening the PR.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.

2. Maintainer requires a linked issue — Link the relevant issue (for example `Closes #123`) before opening the PR.
Signal Result Evidence
Code review ❌ 2 blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 2 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 43 registered-repo PR(s), 35 merged, 411 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 43 PR(s), 411 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ⚠️ ℹ️ None detected risk: low · value: none — No structural-improvement signals were detected for this PR. LLM value judgment: minor — A single-line default-path rename that completes a naming cutover is a small, low-risk, well-targeted fix but not itself a significant improvement.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 43 PR(s), 411 issue(s).
  • Related work: Titles/paths share 3 meaningful terms. (PR #5960)
  • Related work: Titles/paths share 3 meaningful terms. (PR #5958, PR #5960)
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Triage stale or unlinked PRs.
  • No action.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 15, 2026
@JSONbored
JSONbored merged commit 1f2d22d into main Jul 15, 2026
18 checks passed
@JSONbored
JSONbored deleted the fix/gittensory-app-env-default-path branch July 15, 2026 01:49
This was referenced Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant