test(miner): fix stale gittensory identifiers in cross-repo-evaluation test - #5913
Conversation
…n test #5899 renamed scanPositiveGittensoryAssumptions -> scanPositiveLoopoverAssumptions and the summary field withoutGittensoryConfig -> withoutLoopoverConfig in packages/loopover-miner/lib/cross-repo-evaluation.js but missed the consuming test file, breaking typecheck (missing export) and one assertion (stale report-text literal) on main.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-14 23:01:31 UTC
🛑 Suggested Action - Manual Review Review summary Nits — 2 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentCI checks failing
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
CI on this PR surfaced a second stale literal from the same commit (#5899) that the first commit here already fixed one instance of: - test/unit/miner-replay-snapshot.test.ts asserted the old .gittensory-replay-snapshots worktree path; the source (replay-snapshot.js's REPLAY_SNAPSHOT_SUBDIR) was already renamed to .loopover-replay-snapshots. - test/unit/miner-coding-task-spec.test.ts asserted the old "Do not assume LoopOver/gittensory CI conventions" prompt text; the source (coding-task-spec.js) already emits "LoopOver/loopover". Audited every file #5899 touched for other real (non-comment) value changes with no remaining stale test literal.
Summary
scanPositiveGittensoryAssumptions→scanPositiveLoopoverAssumptionsand the summary fieldwithoutGittensoryConfig→withoutLoopoverConfiginpackages/loopover-miner/lib/cross-repo-evaluation.js, but missed the consuming test file.npm run typecheckon main (missing export → cascading implicit-any) and one assertion (a stale report-text literal), discovered while rebasing an unrelated PR onto main.test/unit/miner-cross-repo-evaluation.test.tsto use the renamed identifiers/text.Test plan
npm run typecheck— cleannpx vitest run test/unit/miner-cross-repo-evaluation.test.ts— 29/29 passingnpm audit --audit-level=moderate— 0 vulnerabilities