Skip to content

docs(skill): document the extension lint/typecheck checks omitted from reference.md's CI table and test:ci - #5894

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:docs-reference-ci-extension
Jul 15, 2026
Merged

docs(skill): document the extension lint/typecheck checks omitted from reference.md's CI table and test:ci#5894
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
lourincedaging0-commits:docs-reference-ci-extension

Conversation

@lourincedaging0-commits

Copy link
Copy Markdown
Contributor

Closes #5811. Docs-only (two .md files, no code touched).

reference.md's CI table and its "one command for everything except security" claim both omitted the four extension-lane checks that .github/workflows/ci.yml's validate-code job runs (gated on push || ui==true, the same trigger as the existing ui → rows): extension:lint, extension:typecheck, miner-extension:lint, miner-extension:typecheck. They're also absent from npm run test:ci, so the "one command" claim was false.

  • reference.md: adds two CI-table rows (ui → extension lint / ui → extension typecheck) in the existing ui → * style, and corrects the claim — a new callout notes test:ci does not run the extension checks (they gate CI's validate-code but are absent from the test:ci chain), the doc-only branch of the issue's deliverable chore(release): prepare public gittensory launch #2.
  • SKILL.md: same fix for its test:ci = "the entire CI gate" framing (deliverable feat(scoring): add situational score projections #3) — flagged the one exception.

No src/** / package files touched, so nothing enters coverage.include and the test shards skip (docs-only).

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 14, 2026
@loopover-orb

loopover-orb Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 LoopOver is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@JSONbored
JSONbored marked this pull request as draft July 14, 2026 22:27
…from the table and test:ci

reference.md's CI table and its 'one command for everything except security' claim both omitted the four
extension-lane checks (extension:lint/typecheck, miner-extension:lint/typecheck) that ci.yml's validate-code
runs on push || ui==true. Adds table rows for them (matching the ui -> * row style + trigger) and corrects
the claim: test:ci does NOT run the extension checks, so a green local test:ci does not exercise them.
Mirrors the same fix into SKILL.md's 'entire CI gate' framing. Docs-only; no code, no coverage-scope files.

Closes JSONbored#5811
@JSONbored
JSONbored force-pushed the docs-reference-ci-extension branch from ab60881 to 129e56f Compare July 15, 2026 00:12
@JSONbored
JSONbored marked this pull request as ready for review July 15, 2026 00:13
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 4df489d into JSONbored:main Jul 15, 2026
8 checks passed
This was referenced Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(skill): reference.md's CI table and test:ci omit the extension lint/typecheck checks

1 participant