docs(skill): document the extension lint/typecheck checks omitted from reference.md's CI table and test:ci - #5894
Merged
loopover-orb[bot] merged 1 commit intoJul 15, 2026
Conversation
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 LoopOver is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
JSONbored
marked this pull request as draft
July 14, 2026 22:27
…from the table and test:ci reference.md's CI table and its 'one command for everything except security' claim both omitted the four extension-lane checks (extension:lint/typecheck, miner-extension:lint/typecheck) that ci.yml's validate-code runs on push || ui==true. Adds table rows for them (matching the ui -> * row style + trigger) and corrects the claim: test:ci does NOT run the extension checks, so a green local test:ci does not exercise them. Mirrors the same fix into SKILL.md's 'entire CI gate' framing. Docs-only; no code, no coverage-scope files. Closes JSONbored#5811
JSONbored
force-pushed
the
docs-reference-ci-extension
branch
from
July 15, 2026 00:12
ab60881 to
129e56f
Compare
JSONbored
marked this pull request as ready for review
July 15, 2026 00:13
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
This was referenced Jul 15, 2026
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5811. Docs-only (two
.mdfiles, no code touched).reference.md's CI table and its "one command for everything exceptsecurity" claim both omitted the four extension-lane checks that.github/workflows/ci.yml'svalidate-codejob runs (gated onpush || ui==true, the same trigger as the existingui →rows):extension:lint,extension:typecheck,miner-extension:lint,miner-extension:typecheck. They're also absent fromnpm run test:ci, so the "one command" claim was false.ui → extension lint/ui → extension typecheck) in the existingui → *style, and corrects the claim — a new callout notestest:cidoes not run the extension checks (they gate CI'svalidate-codebut are absent from thetest:cichain), the doc-only branch of the issue's deliverable chore(release): prepare public gittensory launch #2.test:ci= "the entire CI gate" framing (deliverable feat(scoring): add situational score projections #3) — flagged the one exception.No
src/**/ package files touched, so nothing enterscoverage.includeand the test shards skip (docs-only).