Skip to content

fix(test): stop hardcoding the current miner version as a golden value #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 14, 2026
Merged

fix(test): stop hardcoding the current miner version as a golden value #5891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions test/unit/miner-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ describe("loopover-miner CLI helpers", () => {
"../../packages/loopover-miner/package.json",
{ with: { type: "json" } }
);
expect(packageJson.default.version).toBe("2.0.0");
const { resolveMinerVersion } = await import(
"../../packages/loopover-miner/lib/version.js"
);
expect(resolveMinerVersion({})).toBe(packageJson.default.version);
});
});

Expand Down Expand Up @@ -318,9 +321,13 @@ describe("loopover-miner startup update check (#2331)", () => {
);
});

it("serves --version without blocking when update checks are disabled", () => {
it("serves --version without blocking when update checks are disabled", async () => {
const packageJson = await import(
"../../packages/loopover-miner/package.json",
{ with: { type: "json" } }
);
const output = runCapture(["--version", "--no-update-check"]);
expect(output).toContain("@loopover/miner/2.0.0");
expect(output).toContain(`@loopover/miner/${packageJson.default.version}`);
});

it("serves --help immediately without waiting for a slow registry check", async () => {
Expand Down